Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if redirects are being written to WARC file #1

Closed
turicas opened this issue Oct 26, 2019 · 2 comments
Closed

Check if redirects are being written to WARC file #1

turicas opened this issue Oct 26, 2019 · 2 comments

Comments

@turicas
Copy link
Owner

turicas commented Oct 26, 2019

If scrapy is skipping redirects, we may not be saving them.

@JustAnotherArchivist
Copy link

Based on a brief scan of Scrapy's and crau's codes, it appears that indeed, redirects are not preserved, though I have not tested this. Specifically, as far as I can tell, crau will write a request record for the initial request and a response record for the final response, and all intermediate responses and requests get ignored.

@turicas
Copy link
Owner Author

turicas commented Jan 27, 2022

Fixed on e5c1ecb.

@turicas turicas closed this as completed Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants