Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xaero's WorldMap 1.37.x ignores LevelMapProperties packet #62

Closed
turikhay opened this issue Dec 27, 2023 · 3 comments
Closed

Xaero's WorldMap 1.37.x ignores LevelMapProperties packet #62

turikhay opened this issue Dec 27, 2023 · 3 comments
Labels
bug Something isn't working java Pull requests that update Java code Xaero

Comments

@turikhay
Copy link
Owner

turikhay commented Dec 27, 2023

Jasper @r3ps4J reported this issue in our Discord.

I've asked Xaero on his Discord server for Patreon members about this bug and he said:

You can work around this by sending the level properties packet before the game sends the world spawn packet

Unfortunately, as far as I know it is not possible with the standard Bukkit API. This has worked before, and Xaero kindly agreed to restore this functionality.

Confirmed to be working:

  • WorldMap 1.36.0 (1.20.1)
  • WorldMap 1.37.8 (1.20.4) (fixed)

Confirmed not to be working:

  • WorldMap 1.37.0+ (1.20.x+)
  • WorldMap 1.37.7 (1.20.4)
@turikhay turikhay added the bug Something isn't working label Dec 27, 2023
@turikhay turikhay changed the title Xaero's mods ignore world_id packets Xaero's mods ignore their world id packets Dec 28, 2023
@turikhay turikhay added the Xaero label Dec 29, 2023
@turikhay
Copy link
Owner Author

turikhay commented Jan 1, 2024

I've filled the bug report on Xaero's Discord for Patreons: https://discord.com/channels/649562312537145366/1189890331823579196

@turikhay turikhay added the java Pull requests that update Java code label Jan 10, 2024
@turikhay turikhay changed the title Xaero's mods ignore their world id packets Xaero's mods (WorldMap 1.37.x, Minimap 23.9.x) ignore LevelMapProperties packet Jan 31, 2024
@turikhay
Copy link
Owner Author

turikhay commented Jan 31, 2024

This issue is expected to be fixed in the upcoming release:

  • WorldMap 1.37.8

@turikhay turikhay changed the title Xaero's mods (WorldMap 1.37.x, Minimap 23.9.x) ignore LevelMapProperties packet Xaero's WorldMap 1.37.x ignore LevelMapProperties packet Feb 2, 2024
@turikhay
Copy link
Owner Author

turikhay commented Feb 2, 2024

This is fixed in the WorldMap 1.37.8, thanks to Xaero.

Fixed "Server" map selection mode not activating properly if the server level ID is sent after the world spawn. Fixes compatibility with MapModCompanion.

@turikhay turikhay closed this as completed Feb 2, 2024
@turikhay turikhay pinned this issue Feb 2, 2024
@turikhay turikhay changed the title Xaero's WorldMap 1.37.x ignore LevelMapProperties packet Xaero's WorldMap 1.37.x ignores LevelMapProperties packet Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working java Pull requests that update Java code Xaero
Projects
None yet
Development

No branches or pull requests

1 participant