Draft initial update for Rush Hour readme #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
case-eee
reviewed
Oct 4, 2016
| @@ -179,6 +190,9 @@ We already have a `PayloadRequest` model and database table, and we know that a | |||
|
|
|||
| A Client has two attributes, an `identifier`, and a `rootUrl`. | |||
|
|
|||
| * **identifier** is skin to a username (e.g. `jumpstartlab`). This will be unique in the universe of our app (no two clients should have the same identifier). | |||
|
@s-espinosa I made one small spelling error comment - once you fix this, go ahead and merge. I'm going to take a stab at adding some more clarification to this tonight |
s-espinosa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@case-eee Draft of the updated Rush Hour readme based on the comments on the M2 Trello board. Items outstanding include:
I wasn't sure what we wanted to do on the first one, and wanted to make sure we were on the same page about how much to give on the second. Let's discuss!