Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

if "=", "==" #291

Merged
merged 1 commit into from Oct 9, 2012

Conversation

Projects
None yet
2 participants
Contributor

thisiswei commented Oct 9, 2012

if @author = login(params[:username], params[:password])

if "=", "=="
if @author = login(params[:username], params[:password])
Contributor

steveklabnik commented Oct 9, 2012

Sooooooooo this isn't strictly wrong, because you often want to use @author later in the if block. That said, we're not, so this is way clearer. Thanks.

steveklabnik added a commit that referenced this pull request Oct 9, 2012

@steveklabnik steveklabnik merged commit 8cd0672 into turingschool:master Oct 9, 2012

Contributor

thisiswei commented Nov 23, 2012

steve , you on top of hn this morning 👍

Contributor

steveklabnik commented Nov 23, 2012

Yep. It's been a while.

mikesea pushed a commit to mikesea/curriculum that referenced this pull request Mar 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment