[pull] master from ruby:master#1033
Merged
Merged
Conversation
gc/mmtk/mmtk.c:480:1: warning: function 'rb_mmtk_gc_thread_bug' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
480 | {
| ^
gc/mmtk/mmtk.c:510:1: warning: function 'rb_mmtk_mutator_thread_panic_handler' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
510 | {
| ^
ruby/mmtk@a57746d575
This reverts commit 3d73cd7, that is no longer needed since ruby/rubygems#8735.
GCC doesn't emit any warning when the -Wno- form is used, so we can't check reliably if the warning option is available: When an unrecognized warning option is requested (e.g., -Wunknown-warning), GCC gives an error stating that the option is not recognized. However, if the -Wno- form is used, the behavior is slightly different: no diagnostic is produced for -Wno-unknown-warning unless other diagnostics are being produced. This allows the use of new -Wno- options with old compilers, but if something goes wrong, the compiler warns that an unrecognized option is present.
GitHub Actions schedule triggers only fire from the default branch, so the daily run defined in tarball-test.yml never executed on ruby_3_3, ruby_3_4, or ruby_4_0. Move the cron into a new dispatcher workflow that calls workflow_dispatch on each branch via a PAT.
Release packages stopped to include `*.tar.bz2` since 3.0.0. https://bugs.ruby-lang.org/issues/16483
Release packages stopped to include `*.tar.bz2` since 3.0.0. https://bugs.ruby-lang.org/issues/16483
The legacy mode (vs2022 + vcvars 14.2) is no longer exercised, so collapse the conditional matrix into the modern 2022 / 2025-vs2026 pair and remove the now-dead setup-env (legacy) step.
The per-OS tarball-test workflows currently hard-code `cd snapshot-*/`
to enter the extracted tarball directory, which prevents callers from
producing tarballs under any other prefix (for example `ruby-3.4.0-rc1`
emitted by `tool/make-snapshot` when given a version argument).
Replace the glob with `cd "${{ inputs.archname }}/"`. Existing snapshot
callers still pass `snapshot-<branch>` so behavior is unchanged for
this repository, but ruby/actions can now reuse the same workflows
from `draft-release.yml` with `ruby-<version>` archnames.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
zizmor flags `cd "${{ inputs.archname }}/"` inside `run:` blocks as
code injection via template expansion: GitHub Actions substitutes the
input value into the shell script verbatim, so a caller passing shell
metacharacters could execute arbitrary code.
Hoist `ARCHNAME: ${{ inputs.archname }}` to the job-level `env:` block
and reference it as `$ARCHNAME` in shell, matching the pattern already
used by tarball-windows.yml (see 942f45b).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
We made a mistake calculating slot sizes during the heap slot sizes refactor. Previously BASE_SLOT_SIZE included RVALUE_OVERHEAD, this was lost during the refactor to use the SLOT macro. The result of this was that when Ruby was compiled with -DRUBY_DEBUG it was assumed that the last word of each slot was RVALUE_OVERHEAD. Because this hadn't been taken into account at allocation time, all slots were effectively one word shorter. This PR adds RVALUE_OVERHEAD to the size calcualted in the SLOT macro directly, so it will be added on to the physically allocated size at allocation time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )