Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Grades revealed when grade is assigned in Gradebook #177

Closed
mhughes2k opened this issue Oct 5, 2016 · 6 comments
Closed

[Regression] Grades revealed when grade is assigned in Gradebook #177

mhughes2k opened this issue Oct 5, 2016 · 6 comments

Comments

@mhughes2k
Copy link

This is a follow up to the #141.

I tested the latest version in the Moodle Plugins directory (2016091401) and found that the behaviour in #141 appears.

I tested our current version installed (2016072601) and found that this behaviour isn't demonstrated.

Which is odd, so I diffed the two and found that in lib.php the upgrade_grade() function has changed.

In 2016072601 there is a clause which checks the assign module instances's blindmarking and revealgrades properties.

In 2016091401this check has disappeared, and it simply calls the assign_grade_item_update() function.

tiiregression

diff.zip

@mhughes2k
Copy link
Author

Any news on this?

@dwinn
Copy link
Contributor

dwinn commented Jan 26, 2017

Hi @mhughes2k ,

This has been fixed in the latest release v2017012501

@dwinn dwinn closed this as completed Jan 26, 2017
@mhughes2k
Copy link
Author

Is that the right version number? 2015??

@dwinn
Copy link
Contributor

dwinn commented Jan 26, 2017

Hi @mhughes2k,

Thanks for noticing this. You are right, 2015012501 was not correct originally. It was correct in the release code, I just made a typing error when closing a number of issues on here and then went back through and edited the comments to fix it. The correct version number is v2017012501.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants
@mhughes2k @dwinn and others