Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#482 plagiarism_turnitin_config #611

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

TomoTsuyuki
Copy link
Contributor

Fix the issue #482

@TomoTsuyuki
Copy link
Contributor Author

This needs to be deployed with #585 to fix all of issues for #482

TomoTsuyuki added a commit to catalyst/moodle-plagiarism_turnitin that referenced this pull request Jan 12, 2022
@dwinn
Copy link
Contributor

dwinn commented Jul 21, 2022

Hi @TomoTsuyuki ,

Thank you for your contribution.

I am a little concerned that this does not check for existing values in the database before changing the index. See how #585 does so. Maybe that needs to be in the code here to prevent issues if there is a null value for that field.

@TomoTsuyuki
Copy link
Contributor Author

Hi @dwinn ,

Thanks for checking my PR.
I updated the code to check the field before changing index as #585 .

@dwinn
Copy link
Contributor

dwinn commented Jul 22, 2022

Hi @TomoTsuyuki,

Thank you for the quick update, was just about to make the change myself as we're keen to get this out in our next release but then I saw you updated. We are in the final stages of preparing a release with some other community pull requests, currently aiming for early next week.

@dwinn dwinn changed the base branch from master to develop July 22, 2022 10:07
@dwinn dwinn merged commit 13f22f1 into turnitin:develop Jul 22, 2022
@TomoTsuyuki
Copy link
Contributor Author

Hi @dwinn

Thank for merging.
Hope the update will save many people :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants