Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lxc turnkey template for lxc 1.0 and ubuntu 14.04 #2

Conversation

Projects
None yet
2 participants
@Dude4Linux
Copy link
Contributor

commented Jul 30, 2014

After doing some investigation, the problem is that the newer version of lxc-create is passing the parameter '--rootfs=/var/lib/lxc/<container_name>/rootfs' to the template. The rootfs may not always be at the default location so the template must be prepared to handle other locations.

The second issue is that on Ubuntu, the default bridge name is 'lxcbr0' and not 'br0'. Other variations are possible on other distributions.

A third issue came up during the testing. Errors were occurring because the locale configuration was not being updated to match the host when running on Ubuntu.

I borrowed some code from the 1.04 version of the lxc-debian template to update the lxc-turnkey template and then used it to successfully install Drupal7 on my Ubuntu 14.04 laptop. I also tested the changes on the TurnKey LXC appliance to make sure they did not cause problems there.

lirazsiri added a commit that referenced this pull request Jul 30, 2014

Merge pull request #2 from Dude4Linux/update-lxc-turnkey-template-for…
…-LXC-1.0-and-Ubuntu-14.04

Update lxc turnkey template for lxc 1.0 and ubuntu 14.04

@lirazsiri lirazsiri merged commit b351703 into turnkeylinux-apps:master Jul 30, 2014

@lirazsiri

This comment has been minimized.

Copy link
Member

commented Jul 30, 2014

John, I love how you managed to track down and fix the issue before I had time to take a look a serious look at the discussion on the site. Kudos :)

@Dude4Linux

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2014

Thanks, I'm just trying to do my part to contribute back to the community for all the benefits I've received. Also we're leaving next week on vacation, and I really needed to either get it fixed or try another approach. Finding and fixing it took less time than installing and configuring VirtualBox.

@Dude4Linux Dude4Linux deleted the Dude4Linux:update-lxc-turnkey-template-for-LXC-1.0-and-Ubuntu-14.04 branch Jul 31, 2014

@Dude4Linux

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2014

Liraz, you might want to take a closer look at the changes in the templates between version 0.8 and 1.0.x. I only looked at things that were causing errors or failures. There may be other things that should be updated before the LXC 1.0 appliance rolls out. BTW, there is a logic error in the way the lxc-debian template handles the rootfs parameter. I'll try to remember to report it upstream when I get back from vacation.

@lirazsiri

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

I know what you mean, sometimes I find a bias to taking action and just
squashing an issue really pays off.

Anyhow, enjoy your vacation. I really appreciate how you've been helping
out. You're not only helping make TurnKey better, you're also setting an
important example. If we get even a small fraction of the community to
be more active and contribute that will make a huge difference.

JedMeister pushed a commit that referenced this pull request Jan 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.