Skip to content
Browse files

bugfix: don't raise an error if we fail to destroy a worker

rational:

1) this isn't necessarily an error. It could just mean the instance was already
   destroyed.

2) the destructor might be called after the watchdog cleans up the undestroyed
   instance (e.g., single split jobs where there is an error in the
   initialization of CloudWorker)
  • Loading branch information...
1 parent e765626 commit 4a8b31a2ea9ae5f3daf6025ef707dafd8b921789 @lirazsiri lirazsiri committed
Showing with 0 additions and 2 deletions.
  1. +0 −2 cloudtask/executor.py
View
2 cloudtask/executor.py
@@ -180,8 +180,6 @@ def _cleanup(self):
if destroyed:
ipaddress, instanceid = destroyed[0]
self.status("destroyed worker %s" % instanceid)
- else:
- raise self.Error("Hub didn't destroy worker instance as requested!")
except:
self.status("failed to destroy worker %s" % self.instanceid)
traceback.print_exc(file=self.logs.worker)

0 comments on commit 4a8b31a

Please sign in to comment.
Something went wrong with that request. Please try again.