Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to specify the appname and substitute the actual hostname into /etc/confconsole/services.txt #1

Closed
wants to merge 1 commit into from

Conversation

tssgery
Copy link

@tssgery tssgery commented Jul 19, 2013

Simple change to:

  • allow users the ability to create a file called /etc/appname that should contain the name of the appliance. The current behavior is that the appname is set to the hostname,. which may not always be appropriate
  • allow users to substitute the hostname into /etc/confconsole/services.txt by using the $hostname keyword (similar to how $ipaddr works today)

@coopstah13
Copy link

Any ETA on this pull request being accepted? Not a blocker, but seems pretty straightforward in the changes made.

@JedMeister
Copy link
Member

Hi there.

I know that it's ridiculously late on this one (over 8 years after the fact...) but I'm trying to clean up a bit and clear up the outstanding pull requests.

I was initially planning to update this (we've done a lot to confconsole since this PR) so it will cleanly merge, then merge it. You can find my code in a branch I've just pushed.

However, it doesn't really do what I think was originally desired or intended. It only changes the name at the top of the advanced menu, not on the initial/main screen of confconsole. So I'm not really sure about merging it now?! Also, considering how long it's been, I imagine that both of you have either moved on to other things and/or no longer care about this.

Also, the other thing that occurs to me, is that as it shows the hostname, why is not changing the hostname enough for the purposes of confconsole? After all, confconsole is configuring the host, not a generic appliance.

So I'm going to close this for now. If either of you and/or someone else still wants this behaviour, perhaps let's discuss further first and if need be, we can open a new PR using the updated code and/or something else.

Having said that, I do quite like the idea of being able to include the hostname and/or perhaps even a FQDN instead/as well as a ip address. That's because some appliances require a domain be set, so displaying that domain in confconsole makes tons of sense.

Anyway, closing this one for now.

@JedMeister JedMeister closed this Nov 5, 2021
JedMeister added a commit that referenced this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants