Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mattermost appliance inithook issues #1189

Closed
JedMeister opened this Issue Sep 4, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@JedMeister
Copy link
Member

commented Sep 4, 2018

The v15.0 Mattermost appliance has a couple of inithook issues which should be addressed ASAP.

  1. Mattermost requires a scheme (i.e. http|https) to be set as part of the domain. However by default the Hub only provides a domain (e.g. www.example.com). The inithook should check for a scheme and if one isn't present, add one. IMO it should default to https.
  2. If the domain is not set, the inithook should set a default (generally www.example.com), however there is a bug in the inithook so that if APP_DOMAIN it is not set, the inithook will fail.

Point 1 should really be further addressed by a TurnKey inithook policy. Namely APP_DOMAIN should never have to include a scheme and should always work with a domain. For appliances that need a scheme, the domain should be checked and one added if required. This should probably go with the other development docs in the TKLDev appliance.

@JedMeister JedMeister added this to the 15.1 milestone Sep 4, 2018

@JedMeister JedMeister self-assigned this Sep 4, 2018

@JedMeister

This comment has been minimized.

Copy link
Member Author

commented Sep 20, 2018

Fixed in the upcoming Mattermost v15.1 release.

The specific fixes are turnkeylinux-apps/mattermost@909c06f & turnkeylinux-apps/mattermost@972275f. There was also another inithook oversight that I fixed here: turnkeylinux-apps/mattermost@977a72c.

Plus a few other bits of tidying up (see the full commit history for details: https://github.com/turnkeylinux-apps/mattermost/commits/master)

@JedMeister JedMeister closed this Sep 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.