Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller name must be more than 3 chars #370

Closed
roux1max opened this issue May 29, 2018 · 3 comments
Closed

Controller name must be more than 3 chars #370

roux1max opened this issue May 29, 2018 · 3 comments

Comments

@roux1max
Copy link

Hi there,
First of all, thanks for the work you do, this plugin is really nice, however I just stumbled upon a crispy little problem.

I didn't check how you include the locale into the links but it seems you use regular expressions. The problem is: If you name one of your Controller AbcController (or anything that has 3 letters or less before "Controller"), the generated URL for this controller does not have the locale in it.

Example :

I have a controller named BsiController with an action, let's say List(). When I want to generate a link to this action using @Html.ActionLink, the resulting link does not include the locale:

@Html.ActionLink("My link", "List", "Bsi") generates the following URL http://localhost:59051/Bsi/List instead of http://localhost:59051/fr/Bsi/List.

Thanks for your time !

@turquoiseowl
Copy link
Owner

This sounds like a known issue that has been raised before, e.g. here: #201

Could you look back at those and get back here if of no help.

Thanks.

@roux1max
Copy link
Author

Thanks for the answer, looks like it is the same problem!

Maybe a little word in the documentation would help future users about that ;)

turquoiseowl added a commit that referenced this issue May 29, 2018
@turquoiseowl
Copy link
Owner

You're right - done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants