Log namespace id in the checkpoint logs#1387
Merged
Merged
Conversation
haaawk
reviewed
May 13, 2024
| async fn run_periodic_checkpoint<C>( | ||
| connection_maker: Arc<C>, | ||
| period: Duration, | ||
| namespace_name: NamespaceName, |
Contributor
There was a problem hiding this comment.
This is not used anywhere, is it?
Member
Author
There was a problem hiding this comment.
we need to pass it so that instrumentation can pick it up. This is how it logs:
2024-05-13T12:00:56.515735Z INFO run_periodic_checkpoint{period=24000s namespace_name=default}: libsql_server: database checkpoint starts
But marin might know a better way
haaawk
approved these changes
May 13, 2024
MarinPostma
approved these changes
May 13, 2024
avinassh
added a commit
to avinassh/libsql
that referenced
this pull request
May 13, 2024
avinassh
added a commit
to avinassh/libsql
that referenced
this pull request
May 15, 2024
shopifyski
pushed a commit
to Shopify/libsql
that referenced
this pull request
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.