parse: unconditionally support CREATE FUNCTION in the grammar#149
Merged
Conversation
In order to keep the grammar definition identical between Wasm and non-Wasm builds, let's support CREATE FUNCTION syntax uncondtionally - it will simply inform the users that user-defined functions support wasn't compiled in, if it wasn't.
Collaborator
|
We are no longer strictly compatible with SQLite after this patch. I think that's fine, which is why I am merging this, but just wanted to say this out loud to be explicit about it. |
MarinPostma
added a commit
that referenced
this pull request
Oct 17, 2023
149: http params: support bool r=MarinPostma a=MarinPostma Support for bools in http params close #146 151: Include content-type header for query response. r=MarinPostma a=BearLemma One thing I'm not sure about is whether it's necessary to include the encoding in the header as well 🤔 Co-authored-by: ad hoc <postma.marin@protonmail.com> Co-authored-by: Jan Plhak <jp@chiselstrike.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to keep the grammar definition identical between Wasm and non-Wasm builds, let's support CREATE FUNCTION syntax uncondtionally - it will simply inform the users that user-defined functions support wasn't compiled in, if it wasn't.