make libsql Conn::is_autocommit synchronous#759
Merged
Horusiath merged 3 commits intoDec 18, 2023
Conversation
MarinPostma
reviewed
Dec 5, 2023
MarinPostma
left a comment
MarinPostma
left a comment
Contributor
There was a problem hiding this comment.
I don't think we should do that, rather, we should accurately report whether a connection is in auto-commit state, either by tracking the state, or querying the server
Horusiath
force-pushed
the
libsql-sync-is_autocommit
branch
from
4f80717 to
3063801
Compare
Horusiath
commented
Dec 12, 2023
| // The `libsql://` protocol is an alias for `https://`. | ||
| let base_url = coerce_url_scheme(&url); | ||
| let url_for_queries = format!("{base_url}/v2/pipeline"); | ||
| let url_for_queries = format!("{base_url}/v3/pipeline"); |
Contributor
Author
There was a problem hiding this comment.
GetAutocommitReq requires Hrana v3 to be used.
penberg
approved these changes
Dec 13, 2023
penberg
left a comment
penberg
left a comment
Collaborator
There was a problem hiding this comment.
Looks sensible to me, but it's best to get explicit ACK from @MarinPostma and/or @LucioFranco.
MarinPostma
suggested changes
Dec 13, 2023
Comment on lines
+278
to
+279
| let [resp, _, get_autocommit] = self | ||
| .send_requests([req, StreamRequest::GetAutocommit, StreamRequest::Close]) |
Contributor
There was a problem hiding this comment.
aren't the results in the wrong order? 🤔
Suggested change
| let [resp, _, get_autocommit] = self | |
| .send_requests([req, StreamRequest::GetAutocommit, StreamRequest::Close]) | |
| let [resp, get_autocommit, _] = self | |
| .send_requests([req, StreamRequest::GetAutocommit, StreamRequest::Close]) |
Contributor
There was a problem hiding this comment.
mind adding a sim test?
Contributor
Author
There was a problem hiding this comment.
This is tested - and changing the order causes some of the tests to fail - hence I flipped the order. I found this pretty weird myself.
MarinPostma
approved these changes
Dec 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential rollback, depending on the result of discussion from #758 .
The original decision to change was this discussion: #653 (comment)