Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of an appservice sender worker #6

Merged
merged 15 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@turt2live
Copy link
Owner

commented Feb 22, 2019

No description provided.

@turt2live turt2live force-pushed the travis/appservices branch 2 times, most recently from cf8341a to 7c81d89 Feb 26, 2019

@turt2live turt2live force-pushed the travis/appservices branch from 7c81d89 to 70278a4 Mar 3, 2019

turt2live added some commits Mar 3, 2019

Fix duplication of namespaces
We need to include the namespaces collection and ensure that the reference is required (this forces EF to delete rather than nullify the ID in the FK)

@turt2live turt2live changed the title [WIP] Appservice Sender First implementation of an appservice sender worker Mar 4, 2019

@turt2live turt2live marked this pull request as ready for review Mar 4, 2019

@turt2live

This comment has been minimized.

Copy link
Owner Author

commented Mar 4, 2019

Asking for review now with the understanding that it does work, but needs work. Have reported issues for the gaps.

@turt2live turt2live requested a review from Half-Shot Mar 4, 2019

{
public static class EventFormatter
{
public static JObject ToClientServerFormat(this EventJson ev)

This comment has been minimized.

Copy link
@Half-Shot

Half-Shot Mar 5, 2019

Collaborator

Presumably this isn't going to handle v1 formats like synapse currently does?

This comment has been minimized.

Copy link
@turt2live

turt2live Mar 5, 2019

Author Owner

v1 as in c2s v1 or v1 as in something else?

This comment has been minimized.

Copy link
@Half-Shot

Half-Shot Mar 5, 2019

Collaborator

I thought appservices still had the "old" format for events which had things like a "user_id" instead of "sender" for backwards compat reasons.

This comment has been minimized.

Copy link
@turt2live

turt2live Mar 5, 2019

Author Owner

Spec says they receive events in the client server format. Sorry ancient appservices, you're going to need to update eventually.

@Half-Shot
Copy link
Collaborator

left a comment

I read through and none of it rang alarm bells, so if it runs it's probably good.

@turt2live turt2live merged commit 450c339 into master Mar 5, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@turt2live turt2live deleted the travis/appservices branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.