Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown-it instead of marked, with todo list plugin #196

Merged
merged 1 commit into from Oct 13, 2016

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Oct 13, 2016

  • markdown format help updated
  • locales files updated with the new strings (only french has been translated, sorry)

You will then be able to use other plugins for markdown-it (advice: use only those which provides access to the plugin through window.markdownitNameOfThePlugin)

Plus markdown format help updated
Plus locales files updated with the new strings (only french has been
translated, sorry)
@orthecreedence orthecreedence merged commit 669ca7e into turtl:master Oct 13, 2016
@orthecreedence
Copy link
Member

This is awesome! Thanks for the work.

Does the check list persist within the note (note.save()) when changed?

@ldidry
Copy link
Contributor Author

ldidry commented Oct 13, 2016

Does the check list persist within the note (note.save()) when changed?

Sorry, I don't understand what you mean. For now, the checklist can't be checked/unckecked: you need to write - [ ] or - [X]. So, it's just a formatting option for now and so the state is saved with the note.

The markdown-it plugin has an option to be able to check/uncheck the list when showing as HTML, but I didn't activate it since it would require some work to save that state correctly.

@orthecreedence
Copy link
Member

That's exactly what I wanted to know. Your implementation is great. Thanks!

@magowiz
Copy link

magowiz commented Feb 19, 2017

Sorry but I didn't understand how to use this feature :
I wrote - [ ] list1 but I only get the bullet of unsorted list before literally "[ ] list1"
I tried this in both versions : mobile-android-0.6.4 and desktop-0.6.4 (linux x64) .
Do I need to do or install something else before I can get the checklist feature ? Does this improvement is to be released on a future version of the client ?

@ldidry
Copy link
Contributor Author

ldidry commented Feb 19, 2017

@magowiz The patch has been merged but the clients haven't been updated. That's why it's not already working.

@berkes
Copy link

berkes commented Feb 22, 2019

FWIW, by now thas has landed. Note that the - for lists is required. So the syntax is:

- [ ] Implement Checkboxes
- [ ] Merge PR
- [ ] Release new clients.

Clicking to check- and have it auto updated is still a todo: turtl/tracker#223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants