New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sharing for individual boards #185

Open
orthecreedence opened this Issue Oct 6, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@orthecreedence
Member

orthecreedence commented Oct 6, 2018

I'm planning on re-using the space sharing interface for this, but in the spaces_users/spaces_invites tables, going to have object_type/object_id fields (ie board/4444, and possibly eventually note/1234).

On the client side, it would be really weird to have a space for each individual board shared, so it might make sense to have a Shared with me space that's automatic and can't be edited/removed. It would list all the individual boards shared with the user. It would not allow adding/removing boards directly (just the "leave" action).

Eventually it would be nice to be able to move these shared boards into spaces in the sharee's own data, however that is a fairly large change with a lot of strange complexities with regard to the syncing system so would have to be v2 of this feature and would be a separate ticket.


Unknowns:

  • Tracking individual shared boards so the system knows they aren't a full space with a set of boards, but rather a single board share
  • Permissions. They are enforced at the space level, not the individual object level. Permissions checking might need to be expanded everywhere.
  • Keep sharing individual notes in mind while building this.

@orthecreedence orthecreedence added this to the Roadmap milestone Oct 6, 2018

@orthecreedence orthecreedence self-assigned this Oct 6, 2018

@orthecreedence orthecreedence changed the title from Implement sharing for individual boards and notes to Implement sharing for individual boards Oct 6, 2018

@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Oct 6, 2018

Actually regarding moving shared boards into local spaces, there might be an easyish workaround. If locally (in the core) the boards had a field called virtual_space_id and the search system did something like WHERE space_id = {{space_id}} OR virtual_space_id = {{space_id}} for the space search, the boards could appear that they were in the space they were "moved" to but would actually still be in their original space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment