New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic (v0.6) logins not always working on v0.7 client #190

Closed
orthecreedence opened this Issue Oct 9, 2018 · 6 comments

Comments

Projects
None yet
1 participant
@orthecreedence
Member

orthecreedence commented Oct 9, 2018

I'm not able to verify this yet. Might have something to do with a space in the password? Need to run some tests here.

@orthecreedence orthecreedence added this to the v0.7.1 milestone Oct 9, 2018

@orthecreedence orthecreedence self-assigned this Oct 9, 2018

@orthecreedence orthecreedence changed the title from Classig (v0.6) logins not always working on v0.7 client to Classic (v0.6) logins not always working on v0.7 client Oct 9, 2018

@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Oct 9, 2018

Nope, all combos I do (even with a known non-working username thanks to one of our users who reported) seem to pass the auth test. This is with the v0.7.0 release build, not the new one with encoding fixes.

Not sure what to make of this. Here's what we know.

  • The client generates the auth for the new server (gets a 403)
  • The client generates v1 auth for the old server, sends it to the old server (gets 401)
  • The client generates v0 auth for the old server, sends it to the old server (gets 401)

So it seems some combination of username/password is causing the v0.6 v1/v0 auth generation to fail. I'm not smelling any encoding issues because the user who reported says their password is pretty straightforward (AND it's in a pw manager, so no chance of mistyping). I'm also seeing in the logs a lot of 403/new followed by 401+401/old, meaning others are having the same problem and just haven't reported it yet.

orthecreedence added a commit to turtl/core-rs that referenced this issue Oct 9, 2018

adding a ton of tests for the v0/v1 auth generation for the old turtl…
… server. these are fed in by an automated test script in the old js (on a diff branch). they all match, so they are no help in tracking down turtl/tracker#190 unfortunately. oh well it was a good try.

@orthecreedence orthecreedence modified the milestones: v0.7.1, v0.7.2 Oct 9, 2018

@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Oct 10, 2018

Added a new release to help debug this:

If anyone is having this issue, open the app and on the login screen, hit "Trouble logging in?" then fill out the form and send the result.

orthecreedence added a commit to turtl/js that referenced this issue Oct 11, 2018

adding a new controller (user login debugger) which bundles most of t…
…he code from v0.6 (tcrypt, sjcl, user model get_auth/get_key) and also calls out to the new core enpoint to debug login info. the idea here is we can feed the same login to both the core and the old login code and see where things differ for people having trouble logging in. this is for turtl/tracker#190
@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Oct 23, 2018

Just a FYI, the lowercase did not fix this issue for the user who reported it. Still waiting to hear back before I can really continue here.

@orthecreedence orthecreedence modified the milestones: v0.7.2, v0.7.3 Oct 31, 2018

@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Nov 5, 2018

I am fully convinced this is just because people were using Framanotes and the servers are lost during upgrade. Added a page for this: https://turtlapp.com/docs/troubleshooting/logging-in/#custom-servers

@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Nov 5, 2018

Spoke too soon! A user actually came back with a real live case of this. Looks like the password is being processed differently in js than in rust. Everything about this screams of an encoding issue. Trying to gather more info from the user.

@orthecreedence orthecreedence reopened this Nov 5, 2018

orthecreedence added a commit to turtl/js that referenced this issue Nov 6, 2018

@orthecreedence

This comment has been minimized.

Member

orthecreedence commented Nov 7, 2018

Confirmed this is working now. Case closed. Hooray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment