Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction address #53

Closed
afterconnery opened this Issue Mar 17, 2019 · 7 comments

Comments

Projects
None yet
2 participants
@afterconnery
Copy link

afterconnery commented Mar 17, 2019

Would it be possible to add the contact to the details of the transactions on the transaction page? Currently I have to try and remember who I sent TRTL to because the contact isnt part of the transaction log details.

@zpalmtree

This comment has been minimized.

Copy link
Collaborator

zpalmtree commented Mar 17, 2019

We could store this client side, however it would be lost when reimporting the wallet. I'm not sure if the inconsistency is worth it...

Probably not too tricky to do, but we would also have to modify the database format.

@afterconnery

This comment has been minimized.

Copy link
Author

afterconnery commented Mar 17, 2019

I read the blog post earlier, good interview btw, and I wanted to explore more of the wallet to check things out. Inconsistency isnt worth it imo. Would a memo space be difficult to add? Maybe that would do the trick for me personally. Its just an idea.

@zpalmtree

This comment has been minimized.

Copy link
Collaborator

zpalmtree commented Mar 17, 2019

Do you mean allow adding a comment, via the 'Transaction Details' screen? If so, that wouldn't be too hard (and we could add that via the send transaction screen as well, I suppose, which would be a little more intuitive)

I don't actually think your idea would be bad, there are already optional fields there, like payment ID, so putting the address / payee name wouldn't be that bad.

Thinking about it now, it would be easy enough to just have a separate DB, mapping transaction hashes to messages/address/payee names, rather than altering the main DB.

@afterconnery

This comment has been minimized.

Copy link
Author

afterconnery commented Mar 18, 2019

I was thinking about adding a field in the send transaction screen.

@zpalmtree

This comment has been minimized.

Copy link
Collaborator

zpalmtree commented Mar 18, 2019

The issue with that is that if we scan a QR code that has all the necessary info, it takes us straight to the confirm screen, so no time to add a memo, unless we want to add additional steps, which I'm not a fan of.

I'm going to see how it looks to add the recipient + address to the transactions we sent, and maybe add an optional memo field there to be filled in later.

Actually... maybe we could add a memo field on the confirm screen - we could use a similar 'change' button to toggle a field, as we did on the modify payee screen.

@zpalmtree

This comment has been minimized.

Copy link
Collaborator

zpalmtree commented Mar 20, 2019

Done:
image

You can add a memo on the transactions screen, address + recipient are saved automatically.

@zpalmtree zpalmtree closed this Mar 20, 2019

@afterconnery

This comment has been minimized.

Copy link
Author

afterconnery commented Mar 20, 2019

I am excited for the new release! Thanks again for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.