Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: Display unlock time / timestamp in list/incoming/outgoing_transfers zedwallet/zedwallet++ #675

Open
zpalmtree opened this Issue Jan 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@zpalmtree
Copy link
Collaborator

zpalmtree commented Jan 3, 2019

It would be nice if an unlock time is present, we could display it when using the list_transfers command (or their sister commands, incoming_transfers and outgoing_transfers).

We could easily pretty print this, pseudocode:

if (tx.unlockTime != 0)
{
    if (tx.unlockTime < 50000000) // this is defined in cryptonoteconfig somewhere, max block number or something like that
    {
         int64_t difference = tx.unlockTime - tx.height;
         if (difference > 0)
         {
             std::cout << "(Unlocks in " << difference << " blocks)" << std::endl;
         }
    }
    else
    {
          // do the same as above and pretty print the timestamp
    }
}

@zpalmtree zpalmtree changed the title ENHANCEMENT: Display unlock time / timestamp in `list/incoming/outgoing_transfers` zedwallet/zedwallet++ ENHANCEMENT: Display unlock time / timestamp in list/incoming/outgoing_transfers zedwallet/zedwallet++ Jan 3, 2019

@therealholger

This comment has been minimized.

Copy link

therealholger commented Jan 9, 2019

Great idea!
So if someone locks transfer to a certain blockcount or timestamp via the services it might be seen in zedwallet too.

dirtybits referenced this issue Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.