Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a logger to WalletBackend #709

Open
zpalmtree opened this Issue Jan 28, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@zpalmtree
Copy link
Collaborator

zpalmtree commented Jan 28, 2019

A logger for WalletBackend would be very desirable. If possible, it would be nice if we could emulate the logger in https://github.com/turtlecoin/turtlecoin-wallet-backend-js/blob/master/lib/Logger.ts

I think it would be worth extending the logger to also add a Component variable, so we can use it more effectively in other parts of the codebase.

One thing I don't like about the current logger is that we have to pass it around everywhere, instead of just being able to import a file and modify a global object. I'm not sure the best way to do this in C++, or even if it is possible.

Desires for logger:

  • Components, so we can filter messages for just one area of the codebase.
  • Log levels (including Disabled)
  • Categories, so we can do further filtering on a component
  • A callback to handle the logger messages, so we can decide whether to log to a file, console, or something else dynamically.

The logger linked above has most of these already, so is a good starting point to work from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.