Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support to cpp-httplib/nigel #713

Open
zpalmtree opened this Issue Jan 29, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@zpalmtree
Copy link
Collaborator

zpalmtree commented Jan 29, 2019

It looks pretty easy to add SSL support to Nigel and thus wallet-api and zedwallet-beta.
https://github.com/yhirose/cpp-httplib#openssl-support

Relevant code: https://github.com/turtlecoin/turtlecoin/blob/development/src/Nigel/Nigel.cpp#L62

Currently, daemon's don't support SSL, unless proxied through something, so I'm not 100% sure on the best way to test this.

Could link into #712, as the blockchain cache API does support SSL

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator

brandonlehmann commented Feb 1, 2019

I've got this about 75% complete. Assigning to myself.

@brandonlehmann

This comment has been minimized.

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator

brandonlehmann commented Feb 1, 2019

Will likely be including the dependency and building it at compile time since it’s finiky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.