Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer relevant asserts #811

Open
zpalmtree opened this issue May 8, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@zpalmtree
Copy link
Collaborator

commented May 8, 2019

Since pretty much everyone runs the daemon in release mode, instead of debug mode, we've ended up where we have a number of asserts which constantly trigger, due to altered/moved/rewritten sections of code.

We probably want to remove or update all these asserts to ensure they are still indeed checking things which should be 'impossible'.

It would also be nice to add more assertions to new code.

I'm not aware how many asserts there are in the current codebase, but it would probably be a good idea to separate this into multiple PR's for ease of reviewing and testing.

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator

commented May 8, 2019

grep -Hrni 'assert('

@zpalmtree

This comment has been minimized.

Copy link
Collaborator Author

commented May 8, 2019

Looks like about 1000 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.