Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer relevant asserts #811

Closed
zpalmtree opened this issue May 8, 2019 · 4 comments
Closed

Remove no longer relevant asserts #811

zpalmtree opened this issue May 8, 2019 · 4 comments

Comments

@zpalmtree
Copy link
Collaborator

@zpalmtree zpalmtree commented May 8, 2019

Since pretty much everyone runs the daemon in release mode, instead of debug mode, we've ended up where we have a number of asserts which constantly trigger, due to altered/moved/rewritten sections of code.

We probably want to remove or update all these asserts to ensure they are still indeed checking things which should be 'impossible'.

It would also be nice to add more assertions to new code.

I'm not aware how many asserts there are in the current codebase, but it would probably be a good idea to separate this into multiple PR's for ease of reviewing and testing.

@brandonlehmann
Copy link
Collaborator

@brandonlehmann brandonlehmann commented May 8, 2019

grep -Hrni 'assert('

@zpalmtree
Copy link
Collaborator Author

@zpalmtree zpalmtree commented May 8, 2019

Looks like about 1000 😬

LeoStehlik added a commit to LeoStehlik/turtlecoin that referenced this issue Feb 29, 2020
brandonlehmann added a commit that referenced this issue Feb 29, 2020
safe to go and part contributing to #811
@brandonlehmann
Copy link
Collaborator

@brandonlehmann brandonlehmann commented Aug 2, 2020

On second thought, this is a horrible good first issue.

giphy

@brandonlehmann
Copy link
Collaborator

@brandonlehmann brandonlehmann commented Oct 23, 2020

This item will not be addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants