Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Formatting & Lowercase Directories in src/ #849

Merged
merged 12 commits into from Jul 28, 2019

Conversation

@brandonlehmann
Copy link
Collaborator

commented Jul 26, 2019

No description provided.

brandonlehmann added some commits Jul 26, 2019

- Little bit of code cleanup
- Standard formatting applied across all files
@zpalmtree
Copy link
Collaborator

left a comment

  • Few auto formatter tweaks requested
  • Do we want to setup a style guide/linter once this is in?
  • Possibly add as a pre commit check / automated post commit?
include/WalletTypes.h Outdated Show resolved Hide resolved
include/WalletTypes.h Outdated Show resolved Hide resolved
src/common/FileSystemShim.h Show resolved Hide resolved
src/CMakeLists.txt Show resolved Hide resolved
src/errors/ValidateParameters.cpp Outdated Show resolved Hide resolved
src/logger/Logger.cpp Outdated Show resolved Hide resolved
src/logger/Logger.h Outdated Show resolved Hide resolved
src/subwallets/SubWallet.cpp Outdated Show resolved Hide resolved
@brandonlehmann

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 26, 2019

  • Few auto formatter tweaks requested

I'll try to sort them out.

  • Do we want to setup a style guide/linter once this is in?

Sure.

  • Possibly add as a pre commit check / automated post commit?

Maybe.

brandonlehmann added some commits Jul 26, 2019

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 27, 2019

Build fixed. CI tests will all pass shortly.

@zpalmtree

This comment has been minimized.

Copy link
Collaborator

commented Jul 27, 2019

OK, will re-review

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 27, 2019

OK, will re-review

jcwtt3

Learn to love it. It's okay.

@zpalmtree
Copy link
Collaborator

left a comment

It's not perfect, but probably as close as we can get if we can fix this lambda issue.

TurtleCoinStyle.xml Outdated Show resolved Hide resolved
src/subwallets/SubWallet.cpp Outdated Show resolved Hide resolved

zpalmtree and others added some commits Jul 28, 2019

Merge pull request #850 from zpalmtree/formatting-update
Update formatting to use clang-format

@zpalmtree zpalmtree force-pushed the housekeeping branch from 107a4e9 to f387914 Jul 28, 2019

@zpalmtree

This comment has been minimized.

Copy link
Collaborator

commented Jul 28, 2019

Build passing now.

@brandonlehmann brandonlehmann merged commit 26e395f into development Jul 28, 2019

4 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@brandonlehmann brandonlehmann deleted the housekeeping branch Jul 28, 2019

LeoStehlik added a commit to derogold/derogold that referenced this pull request Aug 20, 2019

Code Formatting & Lowercase Directories in src/ (turtlecoin#849)
* - Little bit of code cleanup
- Standard formatting applied across all files

* Changing to lowercase directories in src/

* Reformatting

* Style Settings for CLion

* Erroneously removed <space>

* Add .clang-format

* Add script to run clang-format for all files

* TODO: Change IndentPPDirectives to BeforeHash when in mainline

* Update formatting with clang-format

* Remove CLion formatting rules as it can use clang-format directly

* Fix build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.