Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify Windows build instructions #859

Merged
merged 1 commit into from Aug 4, 2019

Conversation

@SoreGums
Copy link
Collaborator

commented Aug 4, 2019

now that VS2017 is behind a login - much easier to
use VS 2019 standalone build tools.

Show resolved Hide resolved README.md
@brandonlehmann

This comment has been minimized.

Copy link
Collaborator

commented Aug 4, 2019

If we’re going down this road, make sure that it works in AppVeyor before merging so that the directions match the CI build as close as possible.

@SoreGums

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2019

on it - seems they have added vs2019 - lets see

@SoreGums

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2019

ok - this is the one - this passes - I'm done

umm - well I'll push squashed one-line version of the install powershell script to go again to make sure the cache thing is working for boost and check that the other clcache is working again.

@SoreGums

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2019

this didn't cache boost...

because prs don't mess with the cache unless enabled to avoid issues

simplify Windows build instructions
now that VS2017 is behind a login - much easier to
use VS 2019 standalone build tools.
also updated AppVeyor to the same
@SoreGums

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 4, 2019

rightio - last one and this can be merged if you like it.

added to request to appveyor to include boost in the image.
appveyor/ci#2969 (comment)

@brandonlehmann brandonlehmann merged commit 6c47abe into turtlecoin:development Aug 4, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SoreGums SoreGums deleted the SoreGums:update-windows-build-instructions branch Aug 4, 2019

SoreGums added a commit that referenced this pull request Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.