Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet upgrader binary #876

Merged

Conversation

@zpalmtree
Copy link
Collaborator

commented Sep 5, 2019

This adds a binary that upgrades the wallet, in a standalone binary rather than part of zedwallet-beta. It's a bit more streamlined for the upgrade process.

I haven't yet added it to the travis / appveyor. If you like the concept, I'll do that.

@SoreGums

This comment has been minimized.

Copy link
Collaborator

commented Sep 5, 2019

Yes please. The Russian person that was in help was difficult to assist them... If this were a thing probably would have been simpler to get them sorted.

This upgrades from turtle-service style wallets too?

@ExtraHash

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

yes, this updates from the old to new format

@SoreGums

This comment has been minimized.

Copy link
Collaborator

commented Sep 5, 2019

For some reason when opening their wallet file in zedwallet-beta it couldn't be opened. I'm guessing something funky with their password and turtle-service... If it worked fine in the Gui that was using turtle-service then something over there was being stupid....

@ExtraHash

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

turtle-service format shouldn't be any different than the zedwallet format, they're the same, so that would be odd

@zpalmtree

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 5, 2019

Could have been very old version 2 format instead of current zedwallet/turtle-service version 6 format, which we dropped support of around 0.8.4 or something.

zpalmtree and others added 4 commits Sep 5, 2019
@zpalmtree

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

Let me add to travis/appveyor before merging

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2019

Aye

@zpalmtree

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 6, 2019

Done. Just needed to update travis, appveyor just globs all *.exe.

@brandonlehmann brandonlehmann merged commit 9b5460e into turtlecoin:development Sep 6, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.