Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default build type set back to 'Release' #879

Merged

Conversation

@brandonlehmann
Copy link
Collaborator

commented Sep 7, 2019

Repeats #812 that appears to have been lost in another PR. CMAKE_BUILD_TYPE is one of those special vars that requires a bit of special handling based upon information available on the CMake mailing lists.

@zpalmtree
Copy link
Collaborator

left a comment

Can we use lower case if/else to fit with the rest of the file?

@brandonlehmann

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 7, 2019

Can we use lower case if/else to fit with the rest of the file?

Yeah, I'm blind as a bat.

@brandonlehmann brandonlehmann merged commit 567c50a into turtlecoin:development Sep 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@brandonlehmann brandonlehmann deleted the brandonlehmann:fix_default_build_type branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.