Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LZ4 Compression With ZSTD Compression, Compression By Default, New DB default parameters, Removing local cache options #886

Merged
merged 10 commits into from Sep 12, 2019

Conversation

@brandonlehmann
Copy link
Collaborator

commented Sep 12, 2019

Piggy backs off #873 and the information found in wrkzcoin/wrkzcoin#4

  • Remove --rocksdb option for the local cache
  • Remove --sqlite option for the local cache
  • Set --db-enable-compression on by default
  • Reduce the default parameters for the DB options
    • 128MB read cache
    • 256MB write cache
    • 125 max open files
    • 4 db thread count
  • TODO: Provide a notice, via the release notes, that it is recommended that Service Operators operate the daemon with higher than default values. Example:
    • 1024MB read cache
    • 1024MB write cache
    • 500 max open files
    • 10 db thread count
wrkzdev and others added 10 commits Sep 2, 2019
Change compression to ZSTD instead of LZ4 due to greater storage savings
…r (and slightly slower) local cache than using SwappedVector storage
@brandonlehmann brandonlehmann changed the title Replace LZ4 Compression With ZSTD Compression, Compression By Default, New DB default parameters Replace LZ4 Compression With ZSTD Compression, Compression By Default, New DB default parameters, Removing local cache options Sep 12, 2019
@@ -160,7 +160,7 @@ namespace DaemonConfig
#ifdef ENABLE_ZSTD_COMPRESSION
("db-enable-compression",
"Enable database compression",
cxxopts::value<bool>(config.enableDbCompression)->default_value("false")->implicit_value("true"))
cxxopts::value<bool>(config.enableDbCompression)->default_value("true"))

This comment has been minimized.

Copy link
@zpalmtree

zpalmtree Sep 12, 2019

Collaborator

What would be the workflow for disabling compression now? TurtleCoind --db-enable-compress false ?

This comment has been minimized.

Copy link
@brandonlehmann

brandonlehmann Sep 12, 2019

Author Collaborator

Yes.

This comment has been minimized.

Copy link
@brandonlehmann

brandonlehmann Sep 12, 2019

Author Collaborator

Up for debate if we should flip the flag such that it's --db-disable-compression. Honestly doesn't matter to me.

This comment has been minimized.

Copy link
@zpalmtree

zpalmtree Sep 12, 2019

Collaborator

I think it's fine as is, I don't see many people wanting to disable it.

@zpalmtree zpalmtree merged commit 678c7d2 into development Sep 12, 2019
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@zpalmtree zpalmtree deleted the zstd branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.