Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
upload artifacts to GH Releases and S3 from GH Actions #920
Following changes have been done in this PR
Two things to do before merging this
Merge this into a new branch for initial testing.
Note: I have found that the zip files uploaded to GH Releases are almost double the size. It may also be the case with S3
Topic of discussion came up in discord regarding why some builds are suddenly failing in GH Actions. The statement was made that they are still technically in beta. While Travis has it's own headaches at times, I'm personally hesitant to move to 100% release building via GH Actions as they haven't be released yet.
I have checked whether the binaries are being actually stripped or not by checking the size, and indeed they are being stripped. I have also tried explicitly specifying the compression level to tar but there wasn't any size difference. Following is a comparison of sizes (in MB) produced from GH Actions and S3 latest zip files.
The size difference only appears to be on ubuntu default strip. I can test with other different strip binaries (if they exist).
I am okay with waiting till GitHub Actions releases officially on November 13th this year for shifting the CI pipeline. It gives me more time for more testing and removing repeated instructions.