From b28b39f811da8d31c97ed2a7e7fe4683b2fe62e0 Mon Sep 17 00:00:00 2001 From: nha Date: Mon, 6 Apr 2026 01:29:25 +0200 Subject: [PATCH 1/5] migrate to Node.js 24 --- .github/workflows/unit_test.yml | 2 +- .node-version | 2 +- .nvmrc | 2 +- action.yml | 2 +- package.json | 2 +- yarn.lock | 14 +++++++++++++- 6 files changed, 18 insertions(+), 6 deletions(-) diff --git a/.github/workflows/unit_test.yml b/.github/workflows/unit_test.yml index 6d7d02a..4681ba4 100644 --- a/.github/workflows/unit_test.yml +++ b/.github/workflows/unit_test.yml @@ -9,6 +9,6 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-node@v4 with: - node-version: 20 + node-version: 24 - run: yarn - run: yarn test diff --git a/.node-version b/.node-version index 2b9cabc..51105aa 100644 --- a/.node-version +++ b/.node-version @@ -1 +1 @@ -20.12.0 +24.0.0 diff --git a/.nvmrc b/.nvmrc index 9ff1949..8753012 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -v20.12.0 +v24.0.0 diff --git a/action.yml b/action.yml index 8f76cb3..a42a1fb 100644 --- a/action.yml +++ b/action.yml @@ -13,5 +13,5 @@ inputs: fail-on-cache-miss: description: 'Fail the action run if the result was not returned from the cache. Useful for tests. "true" or false otherwise' runs: - using: 'node20' + using: 'node24' main: 'dist/index.js' diff --git a/package.json b/package.json index 7043ac6..d3c2bf1 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ }, "devDependencies": { "@types/jest": "^29.5.12", - "@types/node": "^20.12.2", + "@types/node": "^24.0.0", "@types/semver": "^7.5.8", "@types/uuid": "^9.0.8", "@vercel/ncc": "^0.38.1", diff --git a/yarn.lock b/yarn.lock index 0ce0412..f0e3c8d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -888,13 +888,20 @@ resolved "https://registry.npmjs.org/@types/json5/-/json5-0.0.29.tgz" integrity sha512-dRLjCWHYg4oaA77cxO64oO+7JwCwnIzkZPdrrC71jQmQtlhM556pwKo5bUzqvZndkVbeFLIIi+9TC40JNF5hNQ== -"@types/node@*", "@types/node@^20.12.2": +"@types/node@*": version "20.12.2" resolved "https://registry.yarnpkg.com/@types/node/-/node-20.12.2.tgz#9facdd11102f38b21b4ebedd9d7999663343d72e" integrity sha512-zQ0NYO87hyN6Xrclcqp7f8ZbXNbRfoGWNcMvHTPQp9UUrwI0mI7XBz+cu7/W6/VClYo2g63B0cjull/srU7LgQ== dependencies: undici-types "~5.26.4" +"@types/node@^24.0.0": + version "24.12.2" + resolved "https://registry.yarnpkg.com/@types/node/-/node-24.12.2.tgz#353cb161dbf1785ea25e8829ba7ec574c5c629ac" + integrity sha512-A1sre26ke7HDIuY/M23nd9gfB+nrmhtYyMINbjI1zHJxYteKR6qSMX56FsmjMcDb3SMcjJg5BiRRgOCC/yBD0g== + dependencies: + undici-types "~7.16.0" + "@types/semver@^7.5.0": version "7.5.6" resolved "https://registry.npmjs.org/@types/semver/-/semver-7.5.6.tgz" @@ -4008,6 +4015,11 @@ undici-types@~5.26.4: resolved "https://registry.npmjs.org/undici-types/-/undici-types-5.26.5.tgz" integrity sha512-JlCMO+ehdEIKqlFxk6IfVoAUVmgz7cU7zD/h9XZ0qzeosSHmUJVOzSQvvYSYWXkFXC+IfLKSIffhv0sVZup6pA== +undici-types@~7.16.0: + version "7.16.0" + resolved "https://registry.yarnpkg.com/undici-types/-/undici-types-7.16.0.tgz#ffccdff36aea4884cbfce9a750a0580224f58a46" + integrity sha512-Zz+aZWSj8LE6zoxD+xrjh4VfkIG8Ya6LvYkZqtUQGJPZjYl53ypCaUwWqo7eI0x66KBGeRo+mlBEkMSeSZ38Nw== + undici@^5.25.4: version "5.28.2" resolved "https://registry.npmjs.org/undici/-/undici-5.28.2.tgz" From bd5d6456a81b5300306b039b914eac35212e3a77 Mon Sep 17 00:00:00 2001 From: nha Date: Mon, 6 Apr 2026 01:42:39 +0200 Subject: [PATCH 2/5] replace stale AppVeyor URL with GitHub Releases for Windows CI test --- .github/workflows/check_url.yml | 7 +++---- README.md | 29 ----------------------------- 2 files changed, 3 insertions(+), 33 deletions(-) diff --git a/.github/workflows/check_url.yml b/.github/workflows/check_url.yml index 84c6315..21088f7 100644 --- a/.github/workflows/check_url.yml +++ b/.github/workflows/check_url.yml @@ -79,18 +79,17 @@ jobs: shell: bash check-windows: - # https://ci.appveyor.com/project/borkdude/babashka runs-on: windows-latest strategy: matrix: - babashka-url: ['https://ci.appveyor.com/api/buildjobs/hgg0343wy6uj4xog/artifacts/babashka-1.3.190-SNAPSHOT-windows-amd64.zip'] + babashka-url: ['https://github.com/babashka/babashka/releases/download/v1.3.189/babashka-1.3.189-windows-amd64.zip'] steps: - name: Setup Babashka id: setup-babashka-1 uses: turtlequeue/setup-babashka@main with: - babashka-version: 1.3.190-SNAPSHOT + babashka-version: 1.3.189 babashka-url: ${{ matrix.babashka-url }} - name: Check if bb runs fine @@ -101,7 +100,7 @@ jobs: uses: turtlequeue/setup-babashka@main with: - babashka-version: 1.3.190-SNAPSHOT + babashka-version: 1.3.189 babashka-url: ${{ matrix.babashka-url }} fail-on-cache-miss: true diff --git a/README.md b/README.md index 8f306d2..3f1f94e 100644 --- a/README.md +++ b/README.md @@ -40,35 +40,6 @@ However this action is useful still for: - (advanced) using a CI build by specifying a `babashka-url` (see below) -# Use a CI version - -You probably don't want to do that. -Using a CI build of babashka is possible. They can be found on the babashka CI build artefacts or on [appveyor](https://ci.appveyor.com/project/borkdude/babashka) for windows builds. - -Keep in mind that: -- the CI builds from babashka will expire -- the platform detection is up to you - -```yaml -name: install babashka - -on: [push] - -jobs: - simple: - runs-on: ubuntu-latest - steps: - - name: Setup Babashka - uses: turtlequeue/setup-babashka@v1.7.0 - with: - # this will eventually expire - babashka-version: 0.8.157-SNAPSHOT - babashka-url: https://29579-201467090-gh.circle-artifacts.com/0/release/babashka-0.8.157-SNAPSHOT-linux-amd64-static.tar.gz - - - name: Check bb runs - run: bb --version -``` - # License Copyright © 2022-2024 Turtlequeue Ltd From 6342568d8eb252044ef75ad564099706c4110494 Mon Sep 17 00:00:00 2001 From: nha Date: Mon, 6 Apr 2026 01:43:28 +0200 Subject: [PATCH 3/5] move CI version notes to NOTES.md --- NOTES.md | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/NOTES.md b/NOTES.md index c4a5611..6d8440d 100644 --- a/NOTES.md +++ b/NOTES.md @@ -1,5 +1,23 @@ # notes for myself +# Use a CI version + +You probably don't want to do that. +Using a CI build of babashka is possible. They can be found on the [babashka GitHub releases](https://github.com/babashka/babashka/releases) page (for stable builds) or as GitHub Actions artifacts on the babashka repo (expire after 90 days). + +Keep in mind that: +- the CI builds from babashka will expire +- the platform detection is up to you + +```yaml +- name: Setup Babashka + uses: turtlequeue/setup-babashka@v1.7.0 + with: + # this will eventually expire + babashka-version: 0.8.157-SNAPSHOT + babashka-url: https://29579-201467090-gh.circle-artifacts.com/0/release/babashka-0.8.157-SNAPSHOT-linux-amd64-static.tar.gz +``` + # Development ```bash From 632a1db4ff695295352a4314cdcae75e3b3d094e Mon Sep 17 00:00:00 2001 From: nha Date: Mon, 6 Apr 2026 01:45:05 +0200 Subject: [PATCH 4/5] temp: point workflows at node24 to verify no deprecation warnings --- .github/workflows/check_url.yml | 12 ++++++------ .github/workflows/main.yml | 2 +- .github/workflows/self_check.yml | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_url.yml b/.github/workflows/check_url.yml index 21088f7..cd9d910 100644 --- a/.github/workflows/check_url.yml +++ b/.github/workflows/check_url.yml @@ -11,7 +11,7 @@ jobs: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 @@ -20,7 +20,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 fail-on-cache-miss: true @@ -48,7 +48,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 babashka-url: ${{ matrix.babashka-url }} @@ -58,7 +58,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 babashka-url: ${{ matrix.babashka-url }} @@ -86,7 +86,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 @@ -97,7 +97,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6adf922..ba40bfe 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,7 +9,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: 1.3.189 diff --git a/.github/workflows/self_check.yml b/.github/workflows/self_check.yml index dac089e..99cced3 100644 --- a/.github/workflows/self_check.yml +++ b/.github/workflows/self_check.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: ${{ matrix.babashka-version }} @@ -21,7 +21,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@main + uses: turtlequeue/setup-babashka@node24 with: babashka-version: ${{ matrix.babashka-version }} fail-on-cache-miss: true From 1aba3ab2c115a441472a19d27716f90f95de63e3 Mon Sep 17 00:00:00 2001 From: nha Date: Mon, 6 Apr 2026 01:45:39 +0200 Subject: [PATCH 5/5] revert workflows back to @main --- .github/workflows/check_url.yml | 12 ++++++------ .github/workflows/main.yml | 2 +- .github/workflows/self_check.yml | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/check_url.yml b/.github/workflows/check_url.yml index cd9d910..21088f7 100644 --- a/.github/workflows/check_url.yml +++ b/.github/workflows/check_url.yml @@ -11,7 +11,7 @@ jobs: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 @@ -20,7 +20,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 fail-on-cache-miss: true @@ -48,7 +48,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 babashka-url: ${{ matrix.babashka-url }} @@ -58,7 +58,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 babashka-url: ${{ matrix.babashka-url }} @@ -86,7 +86,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 @@ -97,7 +97,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index ba40bfe..6adf922 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,7 +9,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: 1.3.189 diff --git a/.github/workflows/self_check.yml b/.github/workflows/self_check.yml index 99cced3..dac089e 100644 --- a/.github/workflows/self_check.yml +++ b/.github/workflows/self_check.yml @@ -12,7 +12,7 @@ jobs: steps: - name: Setup Babashka id: setup-babashka-1 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: ${{ matrix.babashka-version }} @@ -21,7 +21,7 @@ jobs: - name: Setup Babashka from cache id: setup-babashka-2 - uses: turtlequeue/setup-babashka@node24 + uses: turtlequeue/setup-babashka@main with: babashka-version: ${{ matrix.babashka-version }} fail-on-cache-miss: true