From 5b8bfae0fa89b7e5b9830ae60085ad09d668597b Mon Sep 17 00:00:00 2001 From: jizai1125 <1414589221@qq.com> Date: Mon, 13 May 2024 11:54:29 +0800 Subject: [PATCH] fix(float-button): error when using with `popover`, closes #5933 --- CHANGELOG.en-US.md | 6 +++++ CHANGELOG.zh-CN.md | 6 +++++ src/float-button/src/FloatButton.tsx | 34 +++++++++++++++------------- 3 files changed, 30 insertions(+), 16 deletions(-) diff --git a/CHANGELOG.en-US.md b/CHANGELOG.en-US.md index 0a5229491b4..f4e472231f5 100644 --- a/CHANGELOG.en-US.md +++ b/CHANGELOG.en-US.md @@ -1,5 +1,11 @@ # CHANGELOG +## NEXT_VERSION + +### Fixes + +- Fix `n-float-button` error when using with `popover` component, closes [#5933](https://github.com/tusen-ai/naive-ui/issues/5933). + ## 2.38.2 `2024-05-03` diff --git a/CHANGELOG.zh-CN.md b/CHANGELOG.zh-CN.md index 26fd2398a8e..d66e1f0f841 100644 --- a/CHANGELOG.zh-CN.md +++ b/CHANGELOG.zh-CN.md @@ -1,5 +1,11 @@ # CHANGELOG +## NEXT_VERSION + +### Fixes + +- 修复 `n-float-button` 和 `popover` 一起使用会报错, 关闭 [#5933](https://github.com/tusen-ai/naive-ui/issues/5933) + ## 2.38.2 `2024-05-03` diff --git a/src/float-button/src/FloatButton.tsx b/src/float-button/src/FloatButton.tsx index 54ba27215f9..53f61b45e5b 100644 --- a/src/float-button/src/FloatButton.tsx +++ b/src/float-button/src/FloatButton.tsx @@ -211,7 +211,7 @@ export default defineComponent({ } = this const dirs: DirectiveArguments = [[mousemoveoutside, this.handleMouseleave]] onRender?.() - return withDirectives( + return (
-
- {$slots.default?.()} - {resolveWrappedSlot($slots.description, (children) => { - if (children) { - return ( -
- {children} -
- ) - } - return null - })} -
+ {withDirectives( +
+ {$slots.default?.()} + {resolveWrappedSlot($slots.description, (children) => { + if (children) { + return ( +
+ {children} +
+ ) + } + return null + })} +
, + dirs + )} {menuTrigger ? (
@@ -258,8 +261,7 @@ export default defineComponent({ {resolveSlot($slots.menu, () => [])}
) : null} -
, - dirs + ) } })