Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugs in the new search #1403

Closed
connyduck opened this issue Jul 21, 2019 · 2 comments

Comments

@connyduck
Copy link
Member

commented Jul 21, 2019

  • When i search for #tusky, there are no results. Searching for tusky finds the hashtag. Maybe the # gets not encoded correctly or it needs to be stripped before sending it to the api? Check why it worked with search v1
  • We need to work around tootsuite/mastodon#11365. Its not our fault, but does not look like it will get fixed in Mastodon anytime soon.
  • crash
stacktrace
android.view.ViewRootImpl$CalledFromWrongThreadException: 
  at android.view.ViewRootImpl.checkThread (ViewRootImpl.java:6603)
  at android.view.ViewRootImpl.invalidateChildInParent (ViewRootImpl.java:954)
  at android.view.ViewGroup.invalidateChild (ViewGroup.java:5084)
  at android.view.View.invalidateInternal (View.java:12716)
  at android.view.View.invalidate (View.java:12680)
  at android.view.View.invalidateParentIfNeeded (View.java:12869)
  at android.view.View.clearAnimation (View.java:19131)
  at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.startScaleDownAnimation (SwipeRefreshLayout.java:486)
  at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.setRefreshing (SwipeRefreshLayout.java:472)
  at androidx.swiperefreshlayout.widget.SwipeRefreshLayout.setRefreshing (SwipeRefreshLayout.java:434)
  at com.keylesspalace.tusky.components.search.fragments.SearchFragment$onRefresh$$inlined$schedule$1.run (SearchFragment.java:149)
  at java.util.Timer$TimerImpl.run (Timer.java:284)
@noln

@connyduck connyduck added this to the Tusky 9 milestone Jul 21, 2019

@connyduck

This comment has been minimized.

Copy link
Member Author

commented Jul 28, 2019

Please let me know if you have time to work on this in the next 2 weeks, otherwise i will fix it. @noln @pandasoft0

@noln

This comment has been minimized.

Copy link

commented Jul 28, 2019

charlag added a commit that referenced this issue Aug 3, 2019

@connyduck connyduck closed this in 0b29b03 Aug 4, 2019

noln added a commit to roma-apps/roma-android that referenced this issue Aug 5, 2019

Fix search bugs, fix tuskyapp#1403 (tuskyapp#1440)
# Conflicts:
#	app/src/main/java/tech/bigfig/roma/components/search/fragments/SearchFragment.kt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.