New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating Android 4 #476

Closed
connyduck opened this Issue Dec 2, 2017 · 14 comments

Comments

Projects
None yet
6 participants
@connyduck
Member

connyduck commented Dec 2, 2017

Android 4 causes more and more problems with Tusky development e.g I cannot use vector drawables and compound drawables the way I want. Mastodon instances drop support for TLS 1.1 and workarounds to enable TLS 1.2 an Android 4 do not seem to work.
This hinders development of new features for the 93% of users that have a newer Android version.

Here are the current installation numbers from Google Play:

Android 4.4 | 1,057 | 5.0% | -6.0%
Android 4.3 | 36 | 0.2% | -23.4%
Android 4.2 | 290 | 1.4% | -5.2%
Android 4.1 | 131 | 0.6% | -7.7%
Android 4.0.3 - 4.0.4 | 45 | 0.2% | -6.3%

So my suggestion is, we drop Support for Android 4.0.3 - 4.1 by the end of the year / with the next release, Android 4.2 - 4.3 in 4 month from now and 4.4 in 8 month the latest. Until then I will resolve all crashes on Android 4, but no display bugs or connection errors because that just takes to much time.

@MasterGroosha

This comment has been minimized.

Contributor

MasterGroosha commented Dec 2, 2017

Just wondering: even web-client won't work for Android 4 with TLS 1.1 ?

@connyduck

This comment has been minimized.

Member

connyduck commented Dec 2, 2017

Definitely not with stock browser, Chrome probably ships its own TLS stack.

@MasterGroosha

This comment has been minimized.

Contributor

MasterGroosha commented Dec 2, 2017

Well, since Chrome will work with Mastodon on Android 4, I personally think it's not a bad idea to drop support for this version, since it causes lots of troubles with compability.
Users will still be able to use Mastodon anyway.

@charlag

This comment has been minimized.

Collaborator

charlag commented Dec 2, 2017

I would drop everything below API 16 at least or even below 19.
Drawables are almost never the problem if you assign them programmatically.

@stom79

This comment has been minimized.

stom79 commented Dec 3, 2017

I know that TLS issue is probably not the main reason to stop the support for API < 19. But there is a way to solve connection issues with some instances for Google Play users.
It's what I use with Mastalab but I am not sure to be able to implement it quickly with Tusky. The easiest way would be to give you the pieces of code.

@connyduck

This comment has been minimized.

Member

connyduck commented Jan 31, 2018

Step 1 of the deprecation has been done. 3c795c6

According to Google Play, this affects 2.1% of our users.

@connyduck

This comment has been minimized.

Member

connyduck commented May 10, 2018

Android 4 is now at 3.8% / 800 installs.

@Tagadda

This comment has been minimized.

Tagadda commented Jul 22, 2018

That's because Tusky doesn't work on Android 4 so nobody install it ?
I love Tusky, this is my favourite app for Mastodon.
Unfortunately, I have to use Mastalab since most of my instances only support TLS1.2 and Tusky do not...

@charlag

This comment has been minimized.

Collaborator

charlag commented Jul 26, 2018

@Tagadda that's the main reason supporting Android 4 is such a PITA. We don't want to make an app 2x bigger for everyone because of the old Android versions. Mastalab already does this so Android 4 is covered by at least one good app so I don't see a reason in investing so much time in it.

@stom79

This comment has been minimized.

stom79 commented Jul 26, 2018

@Tagadda
Some stats from Mastalab (Google Play) that do confirm what was said by @connyduck and @charlag

Android 4.4: 2.6%
Android 4.3: 0.2%
Android 4.2: 0.6%
Android 4.1: 0.6%
Android 4.0.3 - 4.0.4: 0,2%

Mastalab might be one of the "most used app" for these Android versions due to the fact, few apps support up-to-date cipher suites for Android < 19 (only because the apk file will increase its size by several Mb).

Also, maintaining a separated release of Tusky for Android <= 4.4, is not a simple matter, especially with some issues with vector icons. If it was only for the cipher suites issue, I would have suggested my help on it.

@charlag

This comment has been minimized.

Collaborator

charlag commented Jul 26, 2018

@stom79 thanks Tom.
It really makes no sense to invest in ever declining platform when we are missing important features like pinned toots or streaming.
@Tagadda I'm sorry to say that but you may be better off using Mastalab or Pinafore

@connyduck

This comment has been minimized.

Member

connyduck commented Aug 25, 2018

Ok, so lets focus on creating a rock solid Tusky 3.x and the throw out 4.4 support in Tusky 4.

@connyduck connyduck added this to the Tusky 4 milestone Aug 25, 2018

@connyduck

This comment has been minimized.

Member

connyduck commented Sep 16, 2018

@kitkatloyalist

This comment has been minimized.

kitkatloyalist commented Oct 27, 2018

the TLS 1.2 solution?

square/okhttp#2372

Android has supported TLS 1.2 since API 16 (android 4.1) but enabled it by default only since API 20 (android "4.4W")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment