Skip to content
This repository was archived by the owner on May 23, 2025. It is now read-only.

improve usability: add shortcuts for compose/send new toot [#505] - #1296

Merged
connyduck merged 3 commits into
tuskyapp:masterfrom
unstabler:impl-simple-shortcuts
May 31, 2019
Merged

connyduck merged 3 commits into
tuskyapp:masterfrom
unstabler:impl-simple-shortcuts

Conversation

@unstabler

Copy link
Copy Markdown
Contributor

https://twingyeo.kr/@cheesekun/102184993516052526

sorry for my bad english > <);

@connyduck

Copy link
Copy Markdown
Collaborator

In MainActivity, there is already code that handles key events. Can we merge the existing code with you new code somehow?

@unstabler

unstabler commented May 30, 2019 •

Copy link
Copy Markdown
Contributor Author

um.. i think onKeyDown will be called for each key event. (ctrl + enter raises onKeyDown(ctrl) onKeyDown(enter) twice)
so i used onKeyShortcut instead to handle multiple-key event > <);

@connyduck

Copy link
Copy Markdown
Collaborator

yes, I understand that, but can you move the code from onKeyDown to onKeyShortcut and see if it still works?

@unstabler

unstabler commented May 31, 2019 •

Copy link
Copy Markdown
Contributor Author

omg it still works! :0

@connyduck

Copy link
Copy Markdown
Collaborator

Ok, I meant the other way round, but this is also fine. Thank you!

@connyduck
connyduck merged commit 91d01bc into tuskyapp:master May 31, 2019
@Mamonbo Mamonbo mentioned this pull request Jan 18, 2020
1 task done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants