Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve usability: add shortcuts for compose/send new toot [#505] #1296

Merged
merged 3 commits into from May 31, 2019

Conversation

Projects
None yet
2 participants
@unstabler
Copy link
Contributor

commented May 30, 2019

https://twingyeo.kr/@cheesekun/102184993516052526

sorry for my bad english > <);

@connyduck

This comment has been minimized.

Copy link
Member

commented May 30, 2019

In MainActivity, there is already code that handles key events. Can we merge the existing code with you new code somehow?

@unstabler

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

um.. i think onKeyDown will be called for each key event. (ctrl + enter raises onKeyDown(ctrl) onKeyDown(enter) twice)
so i used onKeyShortcut instead to handle multiple-key event > <);

@connyduck

This comment has been minimized.

Copy link
Member

commented May 31, 2019

yes, I understand that, but can you move the code from onKeyDown to onKeyShortcut and see if it still works?

@unstabler

This comment has been minimized.

Copy link
Contributor Author

commented May 31, 2019

omg it still works! :0

@connyduck

This comment has been minimized.

Copy link
Member

commented May 31, 2019

Ok, I meant the other way round, but this is also fine. Thank you!

@connyduck connyduck merged commit 91d01bc into tuskyapp:master May 31, 2019

1 check passed

ci/bitrise/a3e773c3c57a894c/pr Passed - Tusky
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.