fix R8 rules to avoid crash when downloading Emoji Font #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
charlag
approved these changes
Jun 8, 2019
connyduck
commented
Jun 8, 2019
| @@ -94,9 +94,10 @@ | |||
|
|
|||
| -dontwarn com.google.errorprone.annotations.* | |||
|
|
|||
| # work around a bug in proguard | |||
| # see https://sourceforge.net/p/proguard/bugs/729/ | |||
| -keepnames public interface com.uber.autodispose.lifecycle.CorrespondingEventsFunction { *; } | |||
There was a problem hiding this comment.
This old rule can be removed as apparently R8 does not have this problem like ProGuard did
pandasoft0
added a commit
to roma-apps/roma-android
that referenced
this pull request
Jun 10, 2019
* 2019 Emoji Update (tuskyapp#1261) * Updated EmojiCompat support: - Fonts are now updatable - Old fonts will automatically be deleted - Noto Emoji is supported - New library version * It will now (hopefully) only look through the emoji font directory if it exists... * Added a noto emoji icon for Android <=6; Font files and their version relation are only loaded once now. * Small bugfix for the noto emoji icon * Changed the initial size of the existingFontFiles list to a constant value * Bugfixes Old files are now (really) deleted The latest version is used as the actuall font Further optimizations * Emoji font update triggers restart dialog * Resized the Noto icon; (Hopefully) fixed EmojiCompat (again) * Redesign report activity (tuskyapp#1295) * Report activity core * Implement navigation * Implement navigation * Update strings * Revert manifest formatting * Implement Done page * Add landscape layout * Implement Note fragment * Create component * Implement simple status adapter * Format code * Add date/time to report statuses * Refactor status view holder * Refactor code * Refactor ViewPager * Replace MaterialButton with Button * Remove unneeded string * Update Text and Check views style * Remove old ReportActivity and rename Report2Activity to ReportActivity * Hide "report to remote instance" checkbox for local accounts * Add account, hashtag and links click handler * Add media preview * Add sensitive content support * Add status expand/collapse support * Update adapter to user adapterPosition instead of stored status * Updated checked change handling * Add polls support to report screen * Add copyright * Set buttonTint at CheckBox * Exclude reblogs from statuses for reports * Change final page check mark size * Update report note screen * Fix typos * Remove unused params from api endpoint * Replace .visibility with show()/hide() * Replace Date().time with System.currentTime... * Add line spacing * Fix close button tint issue * Updated status adapter * fix r8 rules to avoid crash when downloading Emoji Font (tuskyapp#1312) * Fix after merge * Update Dagger & other deps (tuskyapp#1315) * update dagger * update remaining deps * Fix after merge * Fix after merge * Update Android injector, move chat to components * Version: 7.4.86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems R8 is optimizing away too much and the AsyncTask was missing methods. This also explains why it worked in a debug build.
cc @C1710