Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reporting users without statuses #1445

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@connyduck
Copy link
Member

commented Aug 6, 2019

There is a new wave of spambots that don't post but have links in their bio.

Also, delete the statusContent param of ReportActivity as it is used nowhere.

@connyduck connyduck requested a review from charlag Aug 6, 2019

@connyduck

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

Possible improvement for later: Skip the first page of the report activity if there are no statuses to report.

@charlag

charlag approved these changes Aug 6, 2019

Copy link
Collaborator

left a comment

I'm not familiar with reporting part but looks fine?

ret.addAll(list)
return@BiFunction ret
})
if (params.requestedInitialKey == null) {

This comment has been minimized.

Copy link
@charlag

charlag Aug 6, 2019

Collaborator

What is this key and why this check is needed now?

This comment has been minimized.

Copy link
@connyduck

connyduck Aug 6, 2019

Author Member

Its the id of the status that is being reported. Null means user did not select report on a toot but on a profile.

@connyduck connyduck merged commit d13a341 into master Aug 17, 2019

1 check passed

ci/bitrise/a3e773c3c57a894c/pr Passed - Tusky
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.