Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade api level to Android 10 #1537

Merged
merged 13 commits into from Oct 22, 2019

Conversation

@connyduck
Copy link
Member

connyduck commented Oct 15, 2019

closes #1365

I implemented the new sharing api. As a sideeffect there is now no more "compose" launcher shortcut but one shortcut for each account the user is logged in. I also improved our settings tile, it will now no longer open ComposeActivity with the current account, but ask which account to use if multiple are present.

Also I did not fix the deprecated stuff in ComposeActivity to not create merge conflicts. @charlag

@connyduck

This comment has been minimized.

Copy link
Member Author

connyduck commented Oct 15, 2019

I will have to do some more testing before this is ready to merge, but feel free to comment on the code.

@connyduck connyduck requested a review from charlag Oct 15, 2019
@charlag

This comment has been minimized.

Copy link
Collaborator

charlag commented Oct 16, 2019

I'm confused, should I review it or it's not ready yet?

IconCompat.createWithAdaptiveBitmap(outBmp)
}

val person = Person.Builder()

This comment has been minimized.

Copy link
@charlag

charlag Oct 16, 2019

Collaborator

Person.Builder
🤖

.submit(innerSize, innerSize)
.get()

val outBmp = Bitmap.createBitmap(outerSize, outerSize, Bitmap.Config.ARGB_8888)

This comment has been minimized.

Copy link
@charlag

charlag Oct 16, 2019

Collaborator

got me couple of seconds to figure this out, would be nice to have a comment I think?

ShortcutManagerCompat.addDynamicShortcuts(context, listOf(shortcutInfo))

}
.subscribeOn(Schedulers.computation())

This comment has been minimized.

Copy link
@charlag

charlag Oct 16, 2019

Collaborator

Not very good to block computation() for network request. Maybe would be better to split it into two parts.

@Tak

This comment has been minimized.

Copy link
Contributor

Tak commented Oct 17, 2019

Don't we lose direct share without AccountService?

@connyduck

This comment has been minimized.

Copy link
Member Author

connyduck commented Oct 17, 2019

I'm confused, should I review it or it's not ready yet?

Its not yet tested thoroughly, but code hopefully doesn't change too much anymore, so yes thx

Don't we lose direct share without AccountService?

No, the AndroidX library takes care of it. When you add shortcuts via the ShortcutManagerCompat it will work with all api levels that support sharing.

@Tak

This comment has been minimized.

Copy link
Contributor

Tak commented Oct 17, 2019

Are you still getting direct share suggestions for Tusky with this branch?
I'm not (although mine have been weird since I upgraded to 10…)

@connyduck

This comment has been minimized.

Copy link
Member Author

connyduck commented Oct 17, 2019

Yes, but not on all devices. I am investigating why not.

@connyduck

This comment has been minimized.

Copy link
Member Author

connyduck commented Oct 17, 2019

Ok looks like its an issue on the emulator, see https://stackoverflow.com/questions/57396667/directshare-api-with-android-q
It works on all my physical devices.

@connyduck connyduck marked this pull request as ready for review Oct 20, 2019
@connyduck connyduck merged commit 78b5aa8 into develop Oct 22, 2019
1 check passed
1 check passed
ci/bitrise/a3e773c3c57a894c/pr Passed - Tusky
Details
@connyduck connyduck deleted the upgrade_api_level branch Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.