This repository was archived by the owner on May 23, 2025. It is now read-only.
Use light/dark mode colors for image description text - #3003
Merged
Conversation
This is an accessibility issue -- in light mode (which should have dark text on a light background) the text color was hardcoded to light grey and the background color was a semi-transparent black. Fixes #2983.
Tak
approved these changes
Dec 5, 2022
connyduck
reviewed
Dec 5, 2022
Co-authored-by: Konrad Pozniak <connyduck@users.noreply.github.com>
Contributor
Author
|
Good to go I think. I'll take a look at colours in the app separately. A very quick check suggests that not all of the Material3 colour tokens are defined, which is going to lead to weirdness down the line as more widgets are used. In this one, for example, there is a bottom sheet component / style that could be used for the drag handle (for accessibility) and the parent layout (for colours, etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an accessibility issue -- in light mode (which should have dark text on a light background) the text color was hardcoded to light grey and the background color was a semi-transparent black.
Fixes #2983.