New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load public timlines when offscreen #451

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@charlag
Collaborator

charlag commented Nov 12, 2017

This looks hacky but it worked suprisingly well for me.
I am not sure you will agree with this, because it takes time to load but I believe that it's better than constantly fetching timelines user doesn't see.

@connyduck

This comment has been minimized.

Show comment
Hide comment
@connyduck

connyduck Nov 13, 2017

Member

Yes I am really not sure. I personally like it that timelines load in the background, but I can understand that not everybody wants that. I think we need a complete rework of this together with timeline caching.

Member

connyduck commented Nov 13, 2017

Yes I am really not sure. I personally like it that timelines load in the background, but I can understand that not everybody wants that. I think we need a complete rework of this together with timeline caching.

@charlag

This comment has been minimized.

Show comment
Hide comment
@charlag

charlag Nov 13, 2017

Collaborator

It's okay, I understand! But how would caching help? If would request the data from server every time the fragment is requested anyway.

Collaborator

charlag commented Nov 13, 2017

It's okay, I understand! But how would caching help? If would request the data from server every time the fragment is requested anyway.

@connyduck

This comment has been minimized.

Show comment
Hide comment
@connyduck

connyduck Nov 13, 2017

Member

Well we could display cached toots in the background and start a network load once in the foreground, that would hide the network latency better I suppose.
Is it ok if I close this PR for now?

Member

connyduck commented Nov 13, 2017

Well we could display cached toots in the background and start a network load once in the foreground, that would hide the network latency better I suppose.
Is it ok if I close this PR for now?

@charlag

This comment has been minimized.

Show comment
Hide comment
@charlag

charlag Nov 14, 2017

Collaborator

I will close if, thanks for looking at it.

Collaborator

charlag commented Nov 14, 2017

I will close if, thanks for looking at it.

@charlag charlag closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment