Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upfix sending notifications (this time for reals) #594
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
I'm ready to test! Do you have a scenario? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
connyduck
Apr 20, 2018
Member
Well the bug occured randomly, but when you sent multiple notifications while offline it was almost everytime. And of course please test cancelling and the error case (you can trigger that by answering to deleted toots)
|
Well the bug occured randomly, but when you sent multiple notifications while offline it was almost everytime. And of course please test cancelling and the error case (you can trigger that by answering to deleted toots) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
charlag
Apr 20, 2018
Collaborator
Scenario 1:
- Send multiple toots without network
- Cancel them
They should disappear from notifications and appear in drafts - Passes
Scenario 2:
- Send multiple toots without network
- Enable network
They should eventually be sent, notifications should disappear - Passes
Did I miss something?
|
Scenario 1:
Scenario 2:
Did I miss something? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Should be ok |
connyduck
merged commit 79f7f88
into
master
Apr 22, 2018
1 check passed
ci/bitrise/55b2f0c77c4bba74/pr
Passed - Tusky
Details
connyduck
referenced this pull request
Apr 22, 2018
Closed
"Sending toot..." doesn't always disappear when it should #598
connyduck
deleted the
fix-sending-notifications
branch
Apr 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
connyduck commentedApr 20, 2018
•
edited
Edited 1 time
-
connyduck
edited Apr 20, 2018 (most recent)
would be good if somebody could test this before I merge it
fixes #589
edit: here is the link to the apk download https://www.bitrise.io/artifact/5486423/p/bed75ffb8168425de2cd9d3d071d6af4