fix sending notifications (this time for reals) #594

Merged
merged 1 commit into from Apr 22, 2018

Conversation

Projects
None yet
2 participants
@connyduck
Member

connyduck commented Apr 20, 2018

would be good if somebody could test this before I merge it
fixes #589
edit: here is the link to the apk download https://www.bitrise.io/artifact/5486423/p/bed75ffb8168425de2cd9d3d071d6af4

@charlag

This comment has been minimized.

Show comment
Hide comment
@charlag

charlag Apr 20, 2018

Collaborator

I'm ready to test! Do you have a scenario?

Collaborator

charlag commented Apr 20, 2018

I'm ready to test! Do you have a scenario?

@connyduck

This comment has been minimized.

Show comment
Hide comment
@connyduck

connyduck Apr 20, 2018

Member

Well the bug occured randomly, but when you sent multiple notifications while offline it was almost everytime. And of course please test cancelling and the error case (you can trigger that by answering to deleted toots)

Member

connyduck commented Apr 20, 2018

Well the bug occured randomly, but when you sent multiple notifications while offline it was almost everytime. And of course please test cancelling and the error case (you can trigger that by answering to deleted toots)

@charlag

This comment has been minimized.

Show comment
Hide comment
@charlag

charlag Apr 20, 2018

Collaborator

Scenario 1:

  • Send multiple toots without network
  • Cancel them
    They should disappear from notifications and appear in drafts
  • Passes

Scenario 2:

  • Send multiple toots without network
  • Enable network
    They should eventually be sent, notifications should disappear
  • Passes

Did I miss something?

Collaborator

charlag commented Apr 20, 2018

Scenario 1:

  • Send multiple toots without network
  • Cancel them
    They should disappear from notifications and appear in drafts
  • Passes

Scenario 2:

  • Send multiple toots without network
  • Enable network
    They should eventually be sent, notifications should disappear
  • Passes

Did I miss something?

@connyduck

This comment has been minimized.

Show comment
Hide comment
@connyduck

connyduck Apr 22, 2018

Member

Should be ok

Member

connyduck commented Apr 22, 2018

Should be ok

@connyduck connyduck merged commit 79f7f88 into master Apr 22, 2018

1 check passed

ci/bitrise/55b2f0c77c4bba74/pr Passed - Tusky
Details

@connyduck connyduck deleted the fix-sending-notifications branch Apr 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment