New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link's too large hitbox #916

Merged
merged 4 commits into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@kyori19
Copy link
Contributor

kyori19 commented Nov 11, 2018

Fix #846 .

@connyduck
Copy link
Member

connyduck left a comment

Awesome, thx! I confirmed that it works.
But can you please insert a small comment that explains why this code is there? It not very intuitive.
Also, why not use a zero width whitespace instead of a real space?

kyori19 added some commits Nov 12, 2018

@kyori19

This comment has been minimized.

Copy link
Contributor Author

kyori19 commented Nov 12, 2018

I didn't noticed to use non-width space.
I confirmed there's nothing wrong with using it.
And I also added comments to these codes.

@connyduck
Copy link
Member

connyduck left a comment

no need for Html.fromHtml, you can just specify the character like this "\u200B"

@kyori19

This comment has been minimized.

Copy link
Contributor Author

kyori19 commented Nov 12, 2018

Sorry, I changed it.

@connyduck connyduck merged commit ecd4680 into tuskyapp:master Nov 12, 2018

1 of 2 checks passed

ci/circleci: test Your tests failed on CircleCI
Details
ci/bitrise/a3e773c3c57a894c/pr Passed - Tusky
Details

@kyori19 kyori19 deleted the accelforce:fix-846 branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment