Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable microtask hack for Chrome for iOS #1155

Closed
charlag opened this issue Mar 4, 2019 · 0 comments
Closed

Enable microtask hack for Chrome for iOS #1155

charlag opened this issue Mar 4, 2019 · 0 comments
Assignees
@charlag
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Milestone
3.48.2 Bugfix

Comments

@charlag
Copy link
Contributor

charlag commented Mar 4, 2019

There's an old dreaded TransactionInactiveError for which we have "microtask hack" in the IndexerCore. We enabled it for all Safari versions (especially because Safari has tail call elimination and it should be more-or-less safe there) but we detect Chrome on iOS as Chrome because of some downloading quirks (another question if we should do that or not).
We should at least detect that i's iOS and always enable microtask hack there (because it's always Safari under the hood).
@charlag charlag added the bug broken functionality, usability problems, unexpected errors label Mar 4, 2019
@bedhub bedhub added this to the 3.48.2 Bugfix milestone Mar 12, 2019
@charlag charlag self-assigned this Mar 12, 2019
@bedhub bedhub closed this as completed in ad392de Mar 12, 2019
@charlag charlag added the state:tested We tested it and are about to release it label Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charlag charlag

Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.48.2 Bugfix
Development

No branches or pull requests
2 participants
@charlag @bedhub