Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of office notification #241

Closed
mpfau opened this issue Jan 5, 2018 · 27 comments
Closed

Out of office notification #241

mpfau opened this issue Jan 5, 2018 · 27 comments

Comments

@mpfau
Copy link
Contributor

@mpfau mpfau commented Jan 5, 2018

No description provided.

@armhub armhub added this to the Roadmap milestone Dec 11, 2018
@armhub armhub changed the title out of office notification Out of office notification Dec 11, 2018
@charlag charlag added this to Planned in Roadmap Project Jan 30, 2019
@jamesscaur
Copy link

@jamesscaur jamesscaur commented Feb 6, 2019

Yes please!

@jflattery
Copy link

@jflattery jflattery commented Feb 27, 2019

There should be options to only send these notifications to Contacts within your contact-book, as well as within the same domain / organization.

@ghost
Copy link

@ghost ghost commented Jun 28, 2019

Oh, please do give us auto reply as soon as possible. It's the one thing that prevents me using my Tutanota account for everything and giving up on other email services. I need a secure account because of the nature of my work, and the people I advise worldwide need to know how to contact me in emergencies and there is no way to tell them this at present. It's a real problem. Thank you!

@idimitriadis0
Copy link

@idimitriadis0 idimitriadis0 commented Sep 9, 2019

When you implement this feature, please allow the user to edit the Out-of-office subject line as well, or at least to set its language. Thanks!

@acidicX
Copy link

@acidicX acidicX commented Oct 7, 2019

It would be really cool to have an API that can be used to set this, to integrate into other calendar / time tracking solutions.

@ghost
Copy link

@ghost ghost commented Oct 8, 2019

@charlag charlag self-assigned this Jun 15, 2020
bedhub added a commit that referenced this issue Jun 16, 2020
@bedhub
Copy link
Contributor

@bedhub bedhub commented Jun 16, 2020

Created a first prototype for out of office notification

  • Each user should be able to define its own notification message

  • It should be possible to define start and end date, start date is required end date is optional

  • GUI for creating out of office notification, including Subject, Message, Start and End date.

  • allow setting different notifications for members of the same organization?

  • Set a default text, set default dates

  • Support templates

  • Send notification for internal senders

  • Send notification for external senders

  • Prevent loops (send only 1 notification per day to any sender)

  • Restrict sending (abuse, newsletter, notification emails)

@jamesscaur
Copy link

@jamesscaur jamesscaur commented Jun 17, 2020

YES! Thank you @bedhub!

@jamesscaur
Copy link

@jamesscaur jamesscaur commented Jun 17, 2020

Is there any way to get beta access to the prototype?

@mpfau
Copy link
Contributor Author

@mpfau mpfau commented Jun 19, 2020

Not yet. Will probably not take too long...

@dragonfruit637
Copy link

@dragonfruit637 dragonfruit637 commented Jul 21, 2020

Almost finished? It's holiday now, so an out of office notification would be great! Being honest? We need it desperately.

@ECPMF
Copy link

@ECPMF ECPMF commented Sep 3, 2020

there are news on the out of office notification?

@vaf-hub vaf-hub self-assigned this Nov 3, 2020
@vaf-hub
Copy link
Contributor

@vaf-hub vaf-hub commented Nov 16, 2020

After reading RFC3834 I add the following requirements:

When to send:

  • only once in 7 days/24 hours?
  • only if Return-Path address is explicitly part of To, Cc, Bcc,Resent-To, Resent-Cc, Resent-Bcc (not for Catch-All mailbox)

When not to send:

  • original message has one the following headers
  1. Precendence with value "list", "bulk", "junk"
  2. List-* header field
  3. X-Auto-Response-Suppress with value "All" or "OOF" (for exchange senders)
  4. Auto-Submitted with value other than "no"

How:

  • only send to one recipient
  • send message back to envelope sender (Return-Path) (we only send it if envelope sender is also the from header)
  • limit size of message (1024 characters?) and subject (78 characters?)
  • the same notification is sent for all addresses (aliases) belonging to a mailbox

Response format:

  1. In-Reply-To: message-id
  2. References: message-id
  3. From should contain name and address of original recipient
  4. To only one address
  5. Date set to the time the notification is sent
  6. Subject preceeded by "Auto-reply: "
  7. Auto-Submitted: "auto-replied"
@vaf-hub
Copy link
Contributor

@vaf-hub vaf-hub commented Jan 4, 2021

avoid sending out of office notifications for feedback reports, resolved by #2570

@vaf-hub
Copy link
Contributor

@vaf-hub vaf-hub commented Feb 9, 2021

Test notes:

  • check basic functions: define out of office notification for inside and outside and verify the correct message is sent to 1) addresses belonging to the same customer, 2) other Tutanota customers and 3) unsecure external recipients. (secure external are not supported at the moment.)
  • check messages are only sent during time range specified, check corner cases. (it is allowed to only specify a start date and no end date)
  • envelope sender in notifications sent to external senders is not set: <>
  • check no out of office notification is sent as reply to automated mails (mailing lists, github notification etc.) (verify with mail log)
  • no out of office notification is sent if envelope sender is different from from-header of smtp message
  • check that out of office notification is sent after external recipient has clicked the whitelist service link to prove it is not spam
  • sending whitelist request still works (but no requests are sent to automated mails such as those sent by mailing lists, see above)
  • configuring out of office notification with subject length greater than 128 or message greater than 20*1024 is not possible
  • no out of office notification is sent by catch-all mail addresses
  • out of office notification is sent as non-confidential, but invoice and other mail notifications are still confidential
  • out of office notifications are sent from and to the correct email alias
  • a push notification is sent to the recipients alias
  • check that html editor works correctly, changing contents is possible and values are correct if the editor was not rendered and is then rendered again (in EditOutOfOfficeDialog change who receives notifications to hide it), also check other use cases such as EditeSignature
  • try executing sendInfoBatchJob - Out of office notification should not be sent
  • trigger sendFailureNotification
  • try to send internal mail to mailbox with enabled out of office and also have out of office enabled.
vaf-hub added a commit that referenced this issue Feb 15, 2021
@bedhub bedhub closed this in 69a5b78 Feb 16, 2021
Roadmap Project automation moved this from Planned to Done Feb 16, 2021
@bedhub bedhub assigned vitoreiji and unassigned charlag and vaf-hub Feb 18, 2021
@vitoreiji
Copy link
Contributor

@vitoreiji vitoreiji commented Feb 19, 2021

End date of time range is displayed as the next day after saving.

Edit dialog:
image
After saving:
image

In this case, I expect mails sent on the 24th to receive a notification, but I suspect that will not be the case. I'll know tomorrow.

EDIT: As I suspected, the displayed end date is not included in the range.

@vitoreiji
Copy link
Contributor

@vitoreiji vitoreiji commented Feb 19, 2021

Stuff I could not test:

  • whitelist service
  • invoice and other mail notifications are still confidential (how do I trigger invoice mails?)
  • push notifications (could not build android app)
armhub added a commit that referenced this issue Feb 22, 2021
@vaf-hub vaf-hub self-assigned this Feb 22, 2021
@charlag charlag self-assigned this Feb 22, 2021
@vaf-hub
Copy link
Contributor

@vaf-hub vaf-hub commented Feb 23, 2021

Additional Test notes after fixes:

  • try executing sendInfoBatchJob
  • trigger sendFailureNotification
@charlag
Copy link
Contributor

@charlag charlag commented Feb 24, 2021

Empty subject is possible and it looks weird:
Screenshot from 2021-02-24 11-22-18

@charlag
Copy link
Contributor

@charlag charlag commented Feb 24, 2021

I received a OOF from catch-all address, is this how it's intended?

@charlag
Copy link
Contributor

@charlag charlag commented Feb 24, 2021

When both internals have OOF enabled, no OOF is sent at all, even for the first message

@charlag
Copy link
Contributor

@charlag charlag commented Feb 24, 2021

Ah, no, it was my mistake

@charlag charlag reopened this Feb 24, 2021
Roadmap Project automation moved this from Done to In Progress Feb 24, 2021
@charlag
Copy link
Contributor

@charlag charlag commented Feb 24, 2021

Catch all is actually not an issue, I ran into an existing alias

@charlag charlag closed this Feb 24, 2021
Roadmap Project automation moved this from In Progress to Done Feb 24, 2021
@vitoreiji
Copy link
Contributor

@vitoreiji vitoreiji commented Feb 24, 2021

Catch all is actually not an issue, I ran into an existing alias

Now I'm wondering if these notifications should be set per alias...

@charlag
Copy link
Contributor

@charlag charlag commented Feb 24, 2021

They probably should but I think we can start as-is

@jamesscaur
Copy link

@jamesscaur jamesscaur commented May 11, 2021

Screen Shot 2021-05-11 at 19 27 45

Hey guys - more filters on this would be awesome. For example "contacts only" or "non-contacts only"

@charlag
Copy link
Contributor

@charlag charlag commented May 12, 2021

@jamesscaur we don't know your contacts so it wouldn't be possible currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet