Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar importer errors for dates with leading whitespace #3403

Closed
jowlo opened this issue Aug 19, 2021 · 1 comment · Fixed by #3404
Closed

Calendar importer errors for dates with leading whitespace #3403

jowlo opened this issue Aug 19, 2021 · 1 comment · Fixed by #3404
Assignees
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar
Milestone

Comments

@jowlo
Copy link
Contributor

jowlo commented Aug 19, 2021

Bug in web app

Describe the bug
Importing of slightly malformed .ics files produces an (uncaught) error when the time entry has a leading whitespace,

To Reproduce

  1. Import the following file into a calendar, note the leading space on the dates. This file is from a user:
BEGIN:VCALENDAR
BEGIN:VEVENT
SUMMARY:Your fancy meeting
TZID:America/New_York
DTSTART: 20211010T100000
DTEND: 20211010T120000
STATUS:CONFIRMED
ACTION: DISPLAY
CLASS:PUBLIC
METHOD:PUBLISH
UID:myuid@tutanota.com
END:VEVENT
END:VCALENDAR
  1. See error

Expected behavior
Event is imported

Additional context
We parse the date sliced and assume the first 4 digits represent the year. Thus, we are in year 202 here... 🤦‍♂️

@jowlo jowlo added bug broken functionality, usability problems, unexpected errors topic: calendar labels Aug 19, 2021
@johnbotris johnbotris added the state:done meets our definition of done label Sep 14, 2021
@charlag charlag added this to the 3.88.1 milestone Sep 17, 2021
@jowlo
Copy link
Contributor Author

jowlo commented Sep 20, 2021

Test notes

  • Import the example file from the issue description as calendar event. The event should be imported correctly and not show an error
  • Create more ics files that contain tabs and other whitespaces surrounding the date and all should be imported fine.
  • regression: importing a larger ics file works fine as well

@johnbotris johnbotris self-assigned this Sep 21, 2021
@johnbotris johnbotris added the state:tested We tested it and are about to release it label Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants