Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many commands should work when findWidgetVisible #71

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@ganaware
Copy link
Contributor

ganaware commented Feb 17, 2019

When i-searching on the original Emacs, many commands (such as forward-char) cancel i-search then do thier primary work.

This pull-request emulates the above behaviour.
VSCode 1.31 or newer is needed because this pull-request uses arguments to keybindings.

@tuttieee

This comment has been minimized.

Copy link
Owner

tuttieee commented Feb 18, 2019

Thank you very much!

@tuttieee tuttieee merged commit e91108c into tuttieee:master Feb 18, 2019

1 check passed

tuttieee.vscode-emacs-mcx #20190217.2 succeeded
Details
@tuttieee

This comment has been minimized.

Copy link
Owner

tuttieee commented Feb 18, 2019

FYI: an unit test is added: #72

@ganaware ganaware deleted the ganaware:fix/move-command-should-work-when-findWidgetVisisble branch Feb 19, 2019

@ganaware

This comment has been minimized.

Copy link
Contributor Author

ganaware commented Feb 19, 2019

Thank you for merging!

@ganaware ganaware restored the ganaware:fix/move-command-should-work-when-findWidgetVisisble branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.