Option failure_limit does not work #19

Brandon0 opened this Issue Jan 18, 2012 · 1 comment


None yet

2 participants


When the failure_limit option was added back on Dec-01, the code to maintain backwards compatibility was added incorrectly. The code checks for option.failurelimit to not strictly equal null. If the option is omitted (as it should be going forward), the check still returns true (null !== undefined) and then incorrectly overrides any specified value for option.failurelimit to 0. I believe the proper check should be:

if (undefined !== options.failurelimit) {}


Fixed. Thanks for the heads up.

@tuupola tuupola closed this Jan 19, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment