Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made HTTPS detection a bit better. #160

Open
wants to merge 2 commits into
base: 3.x
from

Conversation

Projects
None yet
1 participant
@Frzk
Copy link

Frzk commented Mar 30, 2019

Introduced a new private method isHttps that checks if the request was sent over HTTPS or not.
To do so, it checks if one of the following is true:

  • URI scheme is 'https',
  • a 'X-Forwarded-Proto' header is present and its value is 'https' (useful when running behind a load balancer).

Frzk added some commits Mar 30, 2019

Made HTTPS detection a bit better.
Introduced a new private method `isHttps` that checks if the request was sent over HTTPS or not.
To do so, it checks if one of the following is true:
  - URI scheme is 'https',
  - a 'X-Forwarded-Proto' header is present and its value is 'https' (useful when running behind a load balancer).
Fixed a typo (non breaking space).
This made the tests in Travis-CI fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.