Bundle JS/CSS dependencies for offline use #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline all dependencies from template.html, including nbv.js which previously had to be attached to the generator preview. Note that the [inliner](https://github.com/remy/inliner) tool needs some hacks to be called from a script and does not fail execution when a URL could not be fetched. A more robust alternative would be great. Fixes #5.
tuxu
force-pushed
the
feature/offline-support
branch
from
5dbb4bc
to
0265dff
Compare
tuxu
added a commit
to tuxu/nbviewer-app
that referenced
this pull request
Apr 9, 2022
See tuxu/ipynb-quicklook#10 for details. Fixes #14, #15, and #22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline all dependencies from template.html, including nbv.js which
previously had to be attached to the generator preview.
Note that the inliner tool needs some
hacks to be called from a script and does not fail execution when a URL
could not be fetched. A more robust alternative would be great.
Fixes #5.