Add patch for Object.defineProperties. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Object.defineProperties = function(subject, descs) { | ||
| var vhandler = directProxies.get(subject); | ||
| if (vhandler !== undefined) { | ||
| var names = prim_getOwnPropertyNames(descs); |
There was a problem hiding this comment.
The ES5 spec mentions that only the enumerable own properties of the descs object are considered. So you should use Object.keys here. Also, descs might be a proxy so it's best to call the patched Object.keys, as prim_keys will not work when descs is a proxy.
There was a problem hiding this comment.
Makes sense, thanks.
|
Apart from the comment on |
tvcutsem
added a commit
that referenced
this pull request
May 28, 2015
Add patch for Object.defineProperties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #51.